immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[BUG] Hiding faces not applying to all #1129

New Issue
Closed
opened 2026-02-05 00:34:14 +03:00 by OVERLORD · 7 comments
OVERLORD commented 2026-02-05 00:34:14 +03:00
Owner
Copy Link

Originally created by @abrondijk on GitHub (Jul 20, 2023).

The bug

Hiding faces does not apply to all the faces. Faces that are all the way at the bottom of the list, don't seem to "save" whether its set to hidden or not. Once set to be hidden, they will still show up after clicking "Done". They are also still set to "not hidden" when trying again.

Not sure whether this is related or just a coincidence, but when I scroll to a certain point, the top header starts showing again:
image
It seems as though only faces below this point are not saving. Again, not sure if related or just a coincidence.

I checked the logs of all the pods running and the browser console, but no errors were logged.

Happy to provide more information if requested.

The OS that Immich Server is running on

Ubuntu 22.10

Version of Immich Server

v1.68.0

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

DB_HOSTNAME=immich-database
DB_PORT=5432
IMMICH_MACHINE_LEARNING_URL=http://immich-machine-learning:3003
IMMICH_SERVER_URL=http://immich-server:3001
IMMICH_WEB_URL=http://immich-web:3000
TYPESENSE_HOST=immich-typesense
TZ=Europe/Amsterdam

Reproduction steps

1. Scroll far down when hiding faces
2. Hide most bottom faces
3. Click "Done"

Additional information

No response

Originally created by @abrondijk on GitHub (Jul 20, 2023). ### The bug Hiding faces does not apply to all the faces. Faces that are all the way at the bottom of the list, don't seem to "save" whether its set to hidden or not. Once set to be hidden, they will still show up after clicking "Done". They are also still set to "not hidden" when trying again. Not sure whether this is related or just a coincidence, but when I scroll to a certain point, the top header starts showing again: ![image](https://github.com/immich-app/immich/assets/73667900/88dadaf5-5cc7-46af-8b1c-c472159427ab) It seems as though only faces below this point are not saving. Again, not sure if related or just a coincidence. I checked the logs of all the pods running and the browser console, but no errors were logged. Happy to provide more information if requested. ### The OS that Immich Server is running on Ubuntu 22.10 ### Version of Immich Server v1.68.0 ### Version of Immich Mobile App N/A ### Platform with the issue - [X] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell DB_HOSTNAME=immich-database DB_PORT=5432 IMMICH_MACHINE_LEARNING_URL=http://immich-machine-learning:3003 IMMICH_SERVER_URL=http://immich-server:3001 IMMICH_WEB_URL=http://immich-web:3000 TYPESENSE_HOST=immich-typesense TZ=Europe/Amsterdam ``` ### Reproduction steps ```bash 1. Scroll far down when hiding faces 2. Hide most bottom faces 3. Click "Done" ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 00:34:26 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Jul 20, 2023):

Can your reproduce this bug everytime ? If you reload the page, have the changes been taken into account ?

@martabal commented on GitHub (Jul 20, 2023): Can your reproduce this bug everytime ? If you reload the page, have the changes been taken into account ?
OVERLORD commented 2026-02-05 00:34:29 +03:00
Author
Owner
Copy Link

@abrondijk commented on GitHub (Jul 20, 2023):

I should have mentioned this, I can indeed reproduce the issue everytime. Reloading or force reloading does not change the behaviour.

@abrondijk commented on GitHub (Jul 20, 2023): I should have mentioned this, I can indeed reproduce the issue everytime. Reloading or force reloading does not change the behaviour.
OVERLORD commented 2026-02-05 00:34:33 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Jul 20, 2023):

And when you click on Done, is the notification showing up ?

@martabal commented on GitHub (Jul 20, 2023): And when you click on `Done`, is the notification showing up ?
OVERLORD commented 2026-02-05 00:34:37 +03:00
Author
Owner
Copy Link

@abrondijk commented on GitHub (Jul 20, 2023):

Upon checking whether that notification shows up or not, I believe I have found the cause. I was simply refreshing the page too fast.
If I wait for that notification to show up, it works as expected, if I don't and instead refresh the page before the notification comes up, not everything seems to apply.

Looking at the network requests made upon clicking "Done" confirms this, as its making separate requests for each face to be hidden.

Not sure if that's desirable?

@abrondijk commented on GitHub (Jul 20, 2023): Upon checking whether that notification shows up or not, I believe I have found the cause. I was simply refreshing the page too fast. If I wait for that notification to show up, it works as expected, if I don't and instead refresh the page before the notification comes up, not everything seems to apply. Looking at the network requests made upon clicking "Done" confirms this, as its making separate requests for each face to be hidden. Not sure if that's desirable?
OVERLORD commented 2026-02-05 00:34:41 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Jul 20, 2023):

Yep, that's not really great, I'm working on it to fix this 😁

@martabal commented on GitHub (Jul 20, 2023): Yep, that's not really great, I'm working on it to fix this 😁
OVERLORD commented 2026-02-05 00:34:44 +03:00
Author
Owner
Copy Link

@alextran1502 commented on GitHub (Jul 20, 2023):

@martabal Is this the issue with the server having to handle lots of database transactions before returning the request status? Probably we need to put it in a job queue or something?

@alextran1502 commented on GitHub (Jul 20, 2023): @martabal Is this the issue with the server having to handle lots of database transactions before returning the request status? Probably we need to put it in a job queue or something?
OVERLORD commented 2026-02-05 00:34:52 +03:00
Author
Owner
Copy Link

@martabal commented on GitHub (Jul 20, 2023):

I think it's part of the problem. But I get 2* better performances with a single API call (tested with 50 faces).

@martabal commented on GitHub (Jul 20, 2023): I think it's part of the problem. But I get 2* better performances with a single API call (tested with 50 faces).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1129
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?