immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #6307] [MERGED] refactor(server): split api and jobs into separate e2e suites #11140

New Issue
Closed
opened 2026-02-05 14:34:12 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:34:12 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/6307
Author: @jrasm91
Created: 1/10/2024
Status: ✅ Merged
Merged: 1/10/2024
Merged by: @jrasm91

Base: main ← Head: refactor/e2e-2

📝 Commits (2)

  • b5a0397 refactor: domain and infra modules
  • 5102273 refactor(server): e2e tests

📊 Changes

50 files changed (+852 additions, -439 deletions)

View changed files

📝 .github/workflows/test.yml (+20 -3)
📝 Makefile (+2 -2)
📝 cli/test/e2e/login-key.e2e-spec.ts (+3 -3)
📝 cli/test/e2e/server-info.e2e-spec.ts (+3 -3)
📝 cli/test/e2e/setup.ts (+1 -1)
📝 cli/test/e2e/upload.e2e-spec.ts (+3 -3)
📝 docs/docs/developer/testing.md (+1 -1)
📝 server/e2e/api/client/activity-api.ts (+0 -0)
📝 server/e2e/api/client/album-api.ts (+0 -0)
📝 server/e2e/api/client/api-key-api.ts (+0 -0)
📝 server/e2e/api/client/asset-api.ts (+0 -0)
📝 server/e2e/api/client/auth-api.ts (+0 -0)
📝 server/e2e/api/client/index.ts (+0 -0)
📝 server/e2e/api/client/library-api.ts (+0 -0)
📝 server/e2e/api/client/partner-api.ts (+0 -0)
📝 server/e2e/api/client/server-info-api.ts (+0 -0)
📝 server/e2e/api/client/shared-link-api.ts (+0 -0)
📝 server/e2e/api/client/user-api.ts (+0 -0)
📝 server/e2e/api/jest-e2e.json (+2 -2)
➕ server/e2e/api/setup.ts (+16 -0)

...and 30 more files

📄 Description

In this PR:

  • Split api and jobs e2e tests into two separate suites
  • Add back fsync=off (#4536)
  • Correctly teardown the app in metadata e2e so the test exists promptly

Next steps:

  • Move all api based testing to e2e/api
  • Add more microservices tests, including exiftool
  • Clean up how the CLI e2e tests integrate with the code inside of server/
  • Clean up (separate) e2e and unit fixtures
  • Use the production build on immich-microservices for format testing

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/6307 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 1/10/2024 **Status:** ✅ Merged **Merged:** 1/10/2024 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `refactor/e2e-2` --- ### 📝 Commits (2) - [`b5a0397`](https://github.com/immich-app/immich/commit/b5a039737f89feeac7e6b2754aa08f147a1f4e26) refactor: domain and infra modules - [`5102273`](https://github.com/immich-app/immich/commit/5102273c80d5d8fb3822a56ce61f978120baa1a9) refactor(server): e2e tests ### 📊 Changes **50 files changed** (+852 additions, -439 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+20 -3) 📝 `Makefile` (+2 -2) 📝 `cli/test/e2e/login-key.e2e-spec.ts` (+3 -3) 📝 `cli/test/e2e/server-info.e2e-spec.ts` (+3 -3) 📝 `cli/test/e2e/setup.ts` (+1 -1) 📝 `cli/test/e2e/upload.e2e-spec.ts` (+3 -3) 📝 `docs/docs/developer/testing.md` (+1 -1) 📝 `server/e2e/api/client/activity-api.ts` (+0 -0) 📝 `server/e2e/api/client/album-api.ts` (+0 -0) 📝 `server/e2e/api/client/api-key-api.ts` (+0 -0) 📝 `server/e2e/api/client/asset-api.ts` (+0 -0) 📝 `server/e2e/api/client/auth-api.ts` (+0 -0) 📝 `server/e2e/api/client/index.ts` (+0 -0) 📝 `server/e2e/api/client/library-api.ts` (+0 -0) 📝 `server/e2e/api/client/partner-api.ts` (+0 -0) 📝 `server/e2e/api/client/server-info-api.ts` (+0 -0) 📝 `server/e2e/api/client/shared-link-api.ts` (+0 -0) 📝 `server/e2e/api/client/user-api.ts` (+0 -0) 📝 `server/e2e/api/jest-e2e.json` (+2 -2) ➕ `server/e2e/api/setup.ts` (+16 -0) _...and 30 more files_ </details> ### 📄 Description In this PR: - Split api and jobs e2e tests into two separate suites - Add back `fsync=off` (#4536) - Correctly teardown the app in metadata e2e so the test exists promptly Next steps: - Move all api based testing to e2e/api - Add more microservices tests, including exiftool - Clean up how the CLI e2e tests integrate with the code inside of `server/` - Clean up (separate) e2e and unit fixtures - Use the production build on immich-microservices for format testing --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:34:12 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11140
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?