immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 00:30:57 +03:00
Code Issues 11 Packages Projects Releases 10 Wiki Activity

[BUG] Web Close modal of creating link to share clears the selected photos #1111

New Issue
Closed
opened 2026-02-05 00:30:42 +03:00 by OVERLORD · 2 comments
OVERLORD commented 2026-02-05 00:30:42 +03:00
Owner
Copy Link

Originally created by @tranquanghuy0801 on GitHub (Jul 15, 2023).

The bug

Description:

  • Closing the modal of creating link to share the photos cleared the selected photos, which I think this is not correct behavior. The selected photos should be persisted so the user can continue with other actions such as Download or Archive.

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.67.2

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. On the home page, select some photos
2. At the top, click Share button
3. Close the modal. This action will clear all the selected photos.

Additional information

No response

Originally created by @tranquanghuy0801 on GitHub (Jul 15, 2023). ### The bug Description: - Closing the modal of creating link to share the photos cleared the selected photos, which I think this is not correct behavior. The selected photos should be persisted so the user can continue with other actions such as Download or Archive. ### The OS that Immich Server is running on N/A ### Version of Immich Server v1.67.2 ### Version of Immich Mobile App N/A ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash 1. On the home page, select some photos 2. At the top, click Share button 3. Close the modal. This action will clear all the selected photos. ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 00:30:51 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Aug 3, 2023):

Google photos does leave them selected after going through the create shared link process.

@jrasm91 commented on GitHub (Aug 3, 2023): Google photos does leave them selected after going through the create shared link process.
OVERLORD commented 2026-02-05 00:30:53 +03:00
Author
Owner
Copy Link

@tranquanghuy0801 commented on GitHub (Aug 3, 2023):

@jrasm91 Yeah I understand this. What I meant is it closed the modal when I did not select any photos. Your PR fixed this issue.

@tranquanghuy0801 commented on GitHub (Aug 3, 2023): @jrasm91 Yeah I understand this. What I meant is it closed the modal when I did not select any photos. Your PR fixed this issue.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1111
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?