[PR #5990] [MERGED] refactor(mobile): Activities #11047

Closed
opened 2026-02-05 14:32:38 +03:00 by OVERLORD · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5990
Author: @shenlong-tanwen
Created: 12/26/2023
Status: Merged
Merged: 1/5/2024
Merged by: @alextran1502

Base: mainHead: refactor/mobile-activities-refactor


📝 Commits (10+)

  • 83c7804 refactor: autoroutex pushroute
  • 6b6f05e refactor: autoroutex popRoute
  • 4c0c159 refactor: autoroutex navigate and replace
  • ee1d085 chore: add doc comments for extension methods
  • 6fb8074 refactor: Add LoggerMixin and refactor Album activities to use mixin
  • f314a54 refactor: Activity page
  • 3af85c3 chore: activity user from user constructor
  • 6ed68ff fix: update current asset after build method
  • b83f1a6 refactor: tests with similar structure as lib
  • 243071d chore: remove avoid-declaring-call-method rule from dcm analysis

📊 Changes

108 files changed (+2843 additions, -822 deletions)

View changed files

📝 mobile/analysis_options.yaml (+0 -1)
mobile/dart_test.yaml (+3 -0)
mobile/lib/constants/errors.dart (+9 -0)
📝 mobile/lib/extensions/asyncvalue_extensions.dart (+5 -2)
📝 mobile/lib/extensions/build_context_extensions.dart (+0 -18)
📝 mobile/lib/extensions/datetime_extensions.dart (+3 -2)
📝 mobile/lib/extensions/duration_extensions.dart (+1 -0)
📝 mobile/lib/extensions/string_extensions.dart (+1 -0)
📝 mobile/lib/main.dart (+2 -2)
mobile/lib/mixins/error_logger.mixin.dart (+38 -0)
📝 mobile/lib/module_template/widgets/store_ui_here.txt (+0 -0)
📝 mobile/lib/modules/activities/models/activity.model.dart (+3 -15)
📝 mobile/lib/modules/activities/providers/activity.provider.dart (+41 -108)
mobile/lib/modules/activities/providers/activity.provider.g.dart (+209 -0)
mobile/lib/modules/activities/providers/activity_service.provider.dart (+9 -0)
mobile/lib/modules/activities/providers/activity_service.provider.g.dart (+25 -0)
mobile/lib/modules/activities/providers/activity_statistics.provider.dart (+24 -0)
mobile/lib/modules/activities/providers/activity_statistics.provider.g.dart (+208 -0)
📝 mobile/lib/modules/activities/services/activity.service.dart (+35 -46)
📝 mobile/lib/modules/activities/views/activities_page.dart (+43 -251)

...and 80 more files

📄 Description

Changes made:

  • Custom extensions autoPush, autoPop , autoNavigate and autoRoute are migrated to the extensions pushRoute, popRoute, etc from autoroute
  • Refactored Activity related providers to riverpod_generator based providers
  • Refactored Activity widgets
  • Provider and widget tests added for Activity components

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5990 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 12/26/2023 **Status:** ✅ Merged **Merged:** 1/5/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/mobile-activities-refactor` --- ### 📝 Commits (10+) - [`83c7804`](https://github.com/immich-app/immich/commit/83c7804fd287f3dd83c87ecc883a53fd665895a6) refactor: autoroutex pushroute - [`6b6f05e`](https://github.com/immich-app/immich/commit/6b6f05e1f45f2a38f891250320cc49bbe12481d5) refactor: autoroutex popRoute - [`4c0c159`](https://github.com/immich-app/immich/commit/4c0c159317205db44cea0d483319d7746e055632) refactor: autoroutex navigate and replace - [`ee1d085`](https://github.com/immich-app/immich/commit/ee1d085feef1e9dde7f8ca33978c5deda12b086e) chore: add doc comments for extension methods - [`6fb8074`](https://github.com/immich-app/immich/commit/6fb8074866694e31519ccf4249fc9c939b5e990f) refactor: Add LoggerMixin and refactor Album activities to use mixin - [`f314a54`](https://github.com/immich-app/immich/commit/f314a54df0cfbad57edb49dafc92e8806b7efc24) refactor: Activity page - [`3af85c3`](https://github.com/immich-app/immich/commit/3af85c38a1c0b989b43bd802df21008990ee294d) chore: activity user from user constructor - [`6ed68ff`](https://github.com/immich-app/immich/commit/6ed68ffdf96faf35be1f5196866f97690ec83568) fix: update current asset after build method - [`b83f1a6`](https://github.com/immich-app/immich/commit/b83f1a674f873eb6960b821b09200f527ecf1332) refactor: tests with similar structure as lib - [`243071d`](https://github.com/immich-app/immich/commit/243071d1ebad7bc5556eef9ff003856b4db0aeaf) chore: remove avoid-declaring-call-method rule from dcm analysis ### 📊 Changes **108 files changed** (+2843 additions, -822 deletions) <details> <summary>View changed files</summary> 📝 `mobile/analysis_options.yaml` (+0 -1) ➕ `mobile/dart_test.yaml` (+3 -0) ➕ `mobile/lib/constants/errors.dart` (+9 -0) 📝 `mobile/lib/extensions/asyncvalue_extensions.dart` (+5 -2) 📝 `mobile/lib/extensions/build_context_extensions.dart` (+0 -18) 📝 `mobile/lib/extensions/datetime_extensions.dart` (+3 -2) 📝 `mobile/lib/extensions/duration_extensions.dart` (+1 -0) 📝 `mobile/lib/extensions/string_extensions.dart` (+1 -0) 📝 `mobile/lib/main.dart` (+2 -2) ➕ `mobile/lib/mixins/error_logger.mixin.dart` (+38 -0) 📝 `mobile/lib/module_template/widgets/store_ui_here.txt` (+0 -0) 📝 `mobile/lib/modules/activities/models/activity.model.dart` (+3 -15) 📝 `mobile/lib/modules/activities/providers/activity.provider.dart` (+41 -108) ➕ `mobile/lib/modules/activities/providers/activity.provider.g.dart` (+209 -0) ➕ `mobile/lib/modules/activities/providers/activity_service.provider.dart` (+9 -0) ➕ `mobile/lib/modules/activities/providers/activity_service.provider.g.dart` (+25 -0) ➕ `mobile/lib/modules/activities/providers/activity_statistics.provider.dart` (+24 -0) ➕ `mobile/lib/modules/activities/providers/activity_statistics.provider.g.dart` (+208 -0) 📝 `mobile/lib/modules/activities/services/activity.service.dart` (+35 -46) 📝 `mobile/lib/modules/activities/views/activities_page.dart` (+43 -251) _...and 80 more files_ </details> ### 📄 Description #### Changes made: - Custom extensions `autoPush`, `autoPop` , `autoNavigate` and `autoRoute` are migrated to the extensions `pushRoute`, `popRoute`, etc from `autoroute` - Refactored Activity related providers to riverpod_generator based providers - Refactored Activity widgets - Provider and widget tests added for Activity components --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:32:38 +03:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11047