immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #5976] [MERGED] (mobile): ios - calculate hash using CryptoKit #11039

New Issue
Closed
opened 2026-02-05 14:32:29 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:32:29 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5976
Author: @shenlong-tanwen
Created: 12/26/2023
Status: ✅ Merged
Merged: 1/5/2024
Merged by: @alextran1502

Base: main ← Head: refactor/ios-native-hash

📝 Commits (3)

  • f2adf62 ios: calculate hash using CryptoKit
  • 234425f chore: remove unused crypto dep
  • 7900be6 Merge branch 'main' of github.com:immich-app/immich into refactor/ios-native-hash

📊 Changes

5 files changed (+58 additions, -34 deletions)

View changed files

📝 mobile/ios/Runner/BackgroundSync/BackgroundServicePlugin.swift (+51 -0)
📝 mobile/lib/modules/backup/background_service/background.service.dart (+1 -0)
📝 mobile/lib/shared/services/hash.service.dart (+5 -32)
📝 mobile/pubspec.lock (+1 -1)
📝 mobile/pubspec.yaml (+0 -1)

📄 Description

Changes made in the PR

  • Uses native CryptoKit to calculate SHA-1 hashes in iOS instead of the dart implementation for better performance

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5976 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 12/26/2023 **Status:** ✅ Merged **Merged:** 1/5/2024 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `refactor/ios-native-hash` --- ### 📝 Commits (3) - [`f2adf62`](https://github.com/immich-app/immich/commit/f2adf62c810fd2b1792a6605200e5c48bd1d8ca1) ios: calculate hash using CryptoKit - [`234425f`](https://github.com/immich-app/immich/commit/234425f3d485ab6c43b699b02306d9c451d5f340) chore: remove unused crypto dep - [`7900be6`](https://github.com/immich-app/immich/commit/7900be63309e3f442e15b11e09c5c6b4aea35a1e) Merge branch 'main' of github.com:immich-app/immich into refactor/ios-native-hash ### 📊 Changes **5 files changed** (+58 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `mobile/ios/Runner/BackgroundSync/BackgroundServicePlugin.swift` (+51 -0) 📝 `mobile/lib/modules/backup/background_service/background.service.dart` (+1 -0) 📝 `mobile/lib/shared/services/hash.service.dart` (+5 -32) 📝 `mobile/pubspec.lock` (+1 -1) 📝 `mobile/pubspec.yaml` (+0 -1) </details> ### 📄 Description ### Changes made in the PR - Uses native `CryptoKit` to calculate SHA-1 hashes in iOS instead of the dart implementation for better performance --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:32:29 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11039
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?