immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #5903] [MERGED] feat(server,ml): remove image tagging #11014

New Issue
Closed
opened 2026-02-05 14:32:04 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:32:04 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5903
Author: @mertalev
Created: 12/21/2023
Status: ✅ Merged
Merged: 12/21/2023
Merged by: @mertalev

Base: main ← Head: chore/ml-remove-image-tagging

📝 Commits (5)

📊 Changes

65 files changed (+1003 additions, -2945 deletions)

View changed files

📝 .github/workflows/test.yml (+1 -1)
📝 cli/src/api/open-api/api.ts (+0 -59)
📝 docs/docs/FAQ.md (+0 -4)
📝 docs/docs/developer/architecture.mdx (+1 -1)
📝 docs/docs/install/config-file.md (+0 -8)
📝 machine-learning/README.md (+0 -1)
📝 machine-learning/app/conftest.py (+34 -0)
📝 machine-learning/app/models/__init__.py (+0 -3)
📝 machine-learning/app/models/base.py (+5 -5)
📝 machine-learning/app/models/clip.py (+56 -25)
➖ machine-learning/app/models/image_classification.py (+0 -75)
📝 machine-learning/app/schemas.py (+0 -1)
📝 machine-learning/app/test_main.py (+13 -61)
📝 machine-learning/locustfile.py (+0 -13)
📝 machine-learning/log_conf.json (+1 -2)
📝 machine-learning/poetry.lock (+859 -1997)
📝 machine-learning/pyproject.toml (+3 -13)
📝 mobile/openapi/.openapi-generator/FILES (+0 -3)
📝 mobile/openapi/README.md (+0 -1)
📝 mobile/openapi/doc/AllJobStatusResponseDto.md (+0 -1)

...and 45 more files

📄 Description

Description

This job has been effectively deprecated for some time and is currently disabled by default. The removal of it will be good in several respects:

  1. Many dependencies can be removed from the ML service
  2. Crashes on ARM devices will no longer occur due to the classification model being exported at runtime
  3. Dependency updates can be automated through Renovate
  4. Avoids user confusion -- users often confuse it with the more useful smart search feature

The image size has been shrunk from 1.66gb to 762mb.

The ML service's RAM usage at startup has decreased from 320mb to 215mb.

How Has This Been Tested?

Tested that the server boots up and that the ML endpoints still work.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5903 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 12/21/2023 **Status:** ✅ Merged **Merged:** 12/21/2023 **Merged by:** [@mertalev](https://github.com/mertalev) **Base:** `main` ← **Head:** `chore/ml-remove-image-tagging` --- ### 📝 Commits (5) - [`8cd8fe9`](https://github.com/immich-app/immich/commit/8cd8fe948d493a7dab2e54b668e69b39f1c3c95b) remove image tagging - [`979151f`](https://github.com/immich-app/immich/commit/979151f56daf03460ce699b54d2afcc11a7a0b53) updated lock - [`f12b393`](https://github.com/immich-app/immich/commit/f12b393252e6a651082ecc6f7a4e9e302a90f2fb) fixed tests, improved logging - [`d69db74`](https://github.com/immich-app/immich/commit/d69db74490f1cd684febbaf978aed54a167a58a1) be nice - [`401901d`](https://github.com/immich-app/immich/commit/401901d78d23177b5982e948bba209c6780ae331) fixed tests ### 📊 Changes **65 files changed** (+1003 additions, -2945 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+1 -1) 📝 `cli/src/api/open-api/api.ts` (+0 -59) 📝 `docs/docs/FAQ.md` (+0 -4) 📝 `docs/docs/developer/architecture.mdx` (+1 -1) 📝 `docs/docs/install/config-file.md` (+0 -8) 📝 `machine-learning/README.md` (+0 -1) 📝 `machine-learning/app/conftest.py` (+34 -0) 📝 `machine-learning/app/models/__init__.py` (+0 -3) 📝 `machine-learning/app/models/base.py` (+5 -5) 📝 `machine-learning/app/models/clip.py` (+56 -25) ➖ `machine-learning/app/models/image_classification.py` (+0 -75) 📝 `machine-learning/app/schemas.py` (+0 -1) 📝 `machine-learning/app/test_main.py` (+13 -61) 📝 `machine-learning/locustfile.py` (+0 -13) 📝 `machine-learning/log_conf.json` (+1 -2) 📝 `machine-learning/poetry.lock` (+859 -1997) 📝 `machine-learning/pyproject.toml` (+3 -13) 📝 `mobile/openapi/.openapi-generator/FILES` (+0 -3) 📝 `mobile/openapi/README.md` (+0 -1) 📝 `mobile/openapi/doc/AllJobStatusResponseDto.md` (+0 -1) _...and 45 more files_ </details> ### 📄 Description ## Description This job has been effectively deprecated for some time and is currently disabled by default. The removal of it will be good in several respects: 1. Many dependencies can be removed from the ML service 2. Crashes on ARM devices will no longer occur due to the classification model being exported at runtime 3. Dependency updates can be automated through Renovate 4. Avoids user confusion -- users often confuse it with the more useful smart search feature The image size has been shrunk from 1.66gb to 762mb. The ML service's RAM usage at startup has decreased from 320mb to 215mb. ## How Has This Been Tested? Tested that the server boots up and that the ML endpoints still work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:32:04 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#11014
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?