immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #5511] [CLOSED] feat(web,server): unassign faces (3) #10850

New Issue
Closed
opened 2026-02-05 14:29:10 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:29:10 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5511
Author: @martabal
Created: 12/6/2023
Status: ❌ Closed

Base: main ← Head: feat/un-assign-person-faces

📝 Commits (10+)

  • e231688 feat(web,server): unassign faces
  • 56ff252 fix: e2e test
  • 7e32f8b merge main
  • b64dabd fix: un-assign when clicking on done
  • bbe86a4 move the selected unassigned faces to the person side panel
  • 5a08b7e fix: reset un-assigned person
  • 8aede9e fix: reset re-assigning selected un-assigned face
  • 920026f fix: use face thumbnail and not person face thumbnail when un-assigning face
  • 1484517 merge main
  • 8a69a69 chore: merge main

📊 Changes

43 files changed (+1663 additions, -376 deletions)

View changed files

📝 mobile/openapi/.openapi-generator/FILES (+6 -3)
📝 mobile/openapi/README.md (+5 -2)
📝 mobile/openapi/doc/AssetResponseDto.md (+1 -1)
📝 mobile/openapi/doc/FaceApi.md (+67 -11)
➕ mobile/openapi/doc/PeopleWithFacesResponseDto.md (+16 -0)
📝 mobile/openapi/doc/PersonApi.md (+56 -0)
📝 mobile/openapi/doc/ReassignFaceDto.md (+2 -2)
📝 mobile/openapi/lib/api.dart (+2 -1)
📝 mobile/openapi/lib/api/face_api.dart (+60 -12)
📝 mobile/openapi/lib/api/person_api.dart (+50 -0)
📝 mobile/openapi/lib/api_client.dart (+4 -2)
📝 mobile/openapi/lib/model/asset_response_dto.dart (+15 -5)
➕ mobile/openapi/lib/model/people_with_faces_response_dto.dart (+106 -0)
📝 mobile/openapi/lib/model/reassign_face_dto.dart (+25 -25)
📝 mobile/openapi/test/asset_response_dto_test.dart (+1 -1)
📝 mobile/openapi/test/face_api_test.dart (+8 -3)
➕ mobile/openapi/test/people_with_faces_response_dto_test.dart (+32 -0)
📝 mobile/openapi/test/person_api_test.dart (+5 -0)
📝 mobile/openapi/test/reassign_face_dto_test.dart (+5 -5)
📝 open-api/immich-openapi-specs.json (+117 -19)

...and 23 more files

📄 Description

Changes made in this PR

This PR introduces the ability to un-assign a face from an asset. Once un-assigned, the face can be re-assigned to a new or an existing person.

Fix #5603 too

To do:

  • Global edit
  • Get feedbacks about the flow and change what can be improved.

Next PR will add the ability to manually tag faces within an image.

Screenshots

https://github.com/immich-app/immich/assets/74269598/35eda975-4b27-413f-ade7-acc95faea97b

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5511 **Author:** [@martabal](https://github.com/martabal) **Created:** 12/6/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feat/un-assign-person-faces` --- ### 📝 Commits (10+) - [`e231688`](https://github.com/immich-app/immich/commit/e23168810bbe1c418343f73bddbf46bac33e65ba) feat(web,server): unassign faces - [`56ff252`](https://github.com/immich-app/immich/commit/56ff252b2ea507bc6f25bfe561e85240e56833d6) fix: e2e test - [`7e32f8b`](https://github.com/immich-app/immich/commit/7e32f8b2926ed9fa41fad3c5935881bc8e4520ac) merge main - [`b64dabd`](https://github.com/immich-app/immich/commit/b64dabd6f0303e1e2ffd18f9da823bcd6263283f) fix: un-assign when clicking on done - [`bbe86a4`](https://github.com/immich-app/immich/commit/bbe86a4632a229c7f62e0cddd9266c38c5f8e30c) move the selected unassigned faces to the person side panel - [`5a08b7e`](https://github.com/immich-app/immich/commit/5a08b7e25e2568a8fce202facadb2da0661f82f2) fix: reset un-assigned person - [`8aede9e`](https://github.com/immich-app/immich/commit/8aede9e575b080919ea39593de56911e8973419d) fix: reset re-assigning selected un-assigned face - [`920026f`](https://github.com/immich-app/immich/commit/920026fbc60d2b62514af3bab9e5b740d11ac904) fix: use face thumbnail and not person face thumbnail when un-assigning face - [`1484517`](https://github.com/immich-app/immich/commit/14845174218ae2aa1a5809cbcb0f291842f12721) merge main - [`8a69a69`](https://github.com/immich-app/immich/commit/8a69a69ca60bff4220accb3b0ee2150c5686378f) chore: merge main ### 📊 Changes **43 files changed** (+1663 additions, -376 deletions) <details> <summary>View changed files</summary> 📝 `mobile/openapi/.openapi-generator/FILES` (+6 -3) 📝 `mobile/openapi/README.md` (+5 -2) 📝 `mobile/openapi/doc/AssetResponseDto.md` (+1 -1) 📝 `mobile/openapi/doc/FaceApi.md` (+67 -11) ➕ `mobile/openapi/doc/PeopleWithFacesResponseDto.md` (+16 -0) 📝 `mobile/openapi/doc/PersonApi.md` (+56 -0) 📝 `mobile/openapi/doc/ReassignFaceDto.md` (+2 -2) 📝 `mobile/openapi/lib/api.dart` (+2 -1) 📝 `mobile/openapi/lib/api/face_api.dart` (+60 -12) 📝 `mobile/openapi/lib/api/person_api.dart` (+50 -0) 📝 `mobile/openapi/lib/api_client.dart` (+4 -2) 📝 `mobile/openapi/lib/model/asset_response_dto.dart` (+15 -5) ➕ `mobile/openapi/lib/model/people_with_faces_response_dto.dart` (+106 -0) 📝 `mobile/openapi/lib/model/reassign_face_dto.dart` (+25 -25) 📝 `mobile/openapi/test/asset_response_dto_test.dart` (+1 -1) 📝 `mobile/openapi/test/face_api_test.dart` (+8 -3) ➕ `mobile/openapi/test/people_with_faces_response_dto_test.dart` (+32 -0) 📝 `mobile/openapi/test/person_api_test.dart` (+5 -0) 📝 `mobile/openapi/test/reassign_face_dto_test.dart` (+5 -5) 📝 `open-api/immich-openapi-specs.json` (+117 -19) _...and 23 more files_ </details> ### 📄 Description ## Changes made in this PR This PR introduces the ability to un-assign a face from an asset. Once un-assigned, the face can be re-assigned to a new or an existing person. Fix #5603 too To do: - [x] Global edit - Get feedbacks about the flow and change what can be improved. Next PR will add the ability to manually tag faces within an image. ## Screenshots https://github.com/immich-app/immich/assets/74269598/35eda975-4b27-413f-ade7-acc95faea97b --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:29:10 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10850
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?