immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #5486] [MERGED] feat(web): navigate with keyboard on person page #10835

New Issue
Closed
opened 2026-02-05 14:28:54 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:28:54 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5486
Author: @martabal
Created: 12/4/2023
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @jrasm91

Base: main ← Head: feat/keyboard-navigation-person-pag

📝 Commits (7)

📊 Changes

3 files changed (+81 additions, -22 deletions)

View changed files

📝 web/src/lib/components/elements/buttons/button.svelte (+1 -0)
📝 web/src/lib/components/faces-page/merge-suggestion-modal.svelte (+18 -7)
📝 web/src/routes/(user)/people/[personId]/+page.svelte (+62 -15)

📄 Description

Changes made in this PR

With this PR, users can navigate through suggested people with Tab and Arrow keys. On the suggestion merge modal, pressing the Tab key will only switch between the No and Yes buttons.

Resolves #5400 and #5398

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5486 **Author:** [@martabal](https://github.com/martabal) **Created:** 12/4/2023 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `feat/keyboard-navigation-person-pag` --- ### 📝 Commits (7) - [`234e79d`](https://github.com/immich-app/immich/commit/234e79d012c5004f810d344d2f109b2c09083c71) feat: navigate with keyboard on person page - [`58b6968`](https://github.com/immich-app/immich/commit/58b6968a12b1f19ad0c7f36a3fd4696d3d14cbae) pr feedback - [`06a2fcb`](https://github.com/immich-app/immich/commit/06a2fcb246b15433b15f25ff8e92413535dc1838) pr feedback - [`e39fc56`](https://github.com/immich-app/immich/commit/e39fc56e7f4f1a352b901e4716c37f9871fafae4) merge main - [`b3e9776`](https://github.com/immich-app/immich/commit/b3e9776ff1b0503219182a537103271e085b9571) merge main - [`5bd7a43`](https://github.com/immich-app/immich/commit/5bd7a431c4b39fe3ef8c4f023181fa4086e79e67) pr feedback - [`46d7456`](https://github.com/immich-app/immich/commit/46d74567450fc4f9b5d78a6d0a6d47781b18e4ef) fix: remove unused import ### 📊 Changes **3 files changed** (+81 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/elements/buttons/button.svelte` (+1 -0) 📝 `web/src/lib/components/faces-page/merge-suggestion-modal.svelte` (+18 -7) 📝 `web/src/routes/(user)/people/[personId]/+page.svelte` (+62 -15) </details> ### 📄 Description ## Changes made in this PR With this PR, users can navigate through suggested people with Tab and Arrow keys. On the suggestion merge modal, pressing the Tab key will only switch between the `No` and `Yes` buttons. Resolves #5400 and #5398 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:28:54 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10835
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?