immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #5176] [MERGED] chore(ml): increase spool threshold #10687

New Issue
Closed
opened 2026-02-05 14:26:20 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:26:20 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5176
Author: @mertalev
Created: 11/20/2023
Status: ✅ Merged
Merged: 11/20/2023
Merged by: @alextran1502

Base: main ← Head: chore/ml-increase-spool-threshold

📝 Commits (1)

  • c6d3e1e increase spool threshold to 64MiB

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 machine-learning/app/main.py (+1 -1)

📄 Description

Description

This change intends to fix #5102 by setting the minimum threshold for spooling to 64MiB. The 16MiB limit was meant to be a high enough number that it shouldn't ever come up, but later thumbnail quality options make it feasible to reach this limit. The cause behind #5102 seems to be that Starlette isn't cleaning up spooled files, so further investigation should be done after this PR to understand why.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5176 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 11/20/2023 **Status:** ✅ Merged **Merged:** 11/20/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `chore/ml-increase-spool-threshold` --- ### 📝 Commits (1) - [`c6d3e1e`](https://github.com/immich-app/immich/commit/c6d3e1ea0d6408ef00fe16f220be658db07d5cbf) increase spool threshold to 64MiB ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `machine-learning/app/main.py` (+1 -1) </details> ### 📄 Description ## Description This change intends to fix #5102 by setting the minimum threshold for spooling to 64MiB. The 16MiB limit was meant to be a high enough number that it shouldn't ever come up, but later thumbnail quality options make it feasible to reach this limit. The cause behind #5102 seems to be that Starlette isn't cleaning up spooled files, so further investigation should be done after this PR to understand why. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:26:20 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10687
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?