immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #5138] [MERGED] fix(mobile): use proper context for popping out from share #10668

New Issue
Closed
opened 2026-02-05 14:25:58 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:25:58 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/5138
Author: @shenlong-tanwen
Created: 11/19/2023
Status: ✅ Merged
Merged: 11/19/2023
Merged by: @alextran1502

Base: main ← Head: fix/mobile-share-context

📝 Commits (2)

  • acb376a fix(mobile): use proper context for popping out from share
  • 78aa664 mobile: use proper context for popping

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 mobile/lib/modules/album/ui/album_viewer_appbar.dart (+1 -1)
📝 mobile/lib/modules/asset_viewer/providers/image_viewer_page_state.provider.dart (+1 -1)
📝 mobile/lib/utils/selection_handlers.dart (+1 -1)

📄 Description

Fixes #5119

Changes made in the PR:

  • Uses the proper context object to pop-out from the dialog shown when sharing assets.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/5138 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 11/19/2023 **Status:** ✅ Merged **Merged:** 11/19/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/mobile-share-context` --- ### 📝 Commits (2) - [`acb376a`](https://github.com/immich-app/immich/commit/acb376ab3d24c48b77d06d3192733c8ed2c78b48) fix(mobile): use proper context for popping out from share - [`78aa664`](https://github.com/immich-app/immich/commit/78aa66401ce82d3c93455309c53c545f686a6690) mobile: use proper context for popping ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/album/ui/album_viewer_appbar.dart` (+1 -1) 📝 `mobile/lib/modules/asset_viewer/providers/image_viewer_page_state.provider.dart` (+1 -1) 📝 `mobile/lib/utils/selection_handlers.dart` (+1 -1) </details> ### 📄 Description Fixes #5119 #### Changes made in the PR: - Uses the proper context object to pop-out from the dialog shown when sharing assets. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:25:58 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10668
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?