immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 08:41:28 +03:00
Code Issues 26 Packages Projects Releases 10 Wiki Activity

[BUG] A new isViewingAssetStoreState is created when you get back to Photos page. #1058

New Issue
Closed
opened 2026-02-05 00:15:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 00:15:27 +03:00
Owner
Copy Link

Originally created by @martabal on GitHub (Jul 5, 2023).

The bug

When implementing the new shortcuts feature, I noticed a strange behavior with isViewingAssetStoreState. When you navigate to another page and you get back to Photos page a new isViewingAssetStoreState store is created, but it seems the previous one was not removed.

I added a console.log($isViewingAssetStoreState) here and when a key was pressed I saw this bug.

https://github.com/immich-app/immich/assets/74269598/a2464240-503b-43a1-a05f-e598a3d184d5

(I'm just pressing f to trigger the handleKeyboardPress function)

I'm quiet new with svelte, I don't know if this is the expected behavior.

The OS that Immich Server is running on

Arch

Version of Immich Server

v1.66

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1.From my PR add `console.log($isViewingAssetStoreState)` in asset-grid.svelte line 75
2.Navigate to the Photos page, then proceed to any other page, and finally return to the Photos page.
3.A new instance of isViewingAssetStoreState should have been created,resulting in multiple console logs of the variable. But only one 
...

Additional information

No response

Originally created by @martabal on GitHub (Jul 5, 2023). ### The bug When implementing the [new shortcuts feature](#3111), I noticed a strange behavior with `isViewingAssetStoreState`. When you navigate to another page and you get back to Photos page a new `isViewingAssetStoreState` store is created, but it seems the previous one was not removed. I added a `console.log($isViewingAssetStoreState)` [here](https://github.com/immich-app/immich/pull/3111/files#diff-e35a5970ecd6e1947cf764b6f6192c23f73210e7104d4514e39ac012b7b29495R76) and when a key was pressed I saw this bug. https://github.com/immich-app/immich/assets/74269598/a2464240-503b-43a1-a05f-e598a3d184d5 (I'm just pressing `f` to trigger the `handleKeyboardPress` function) I'm quiet new with svelte, I don't know if this is the expected behavior. ### The OS that Immich Server is running on Arch ### Version of Immich Server v1.66 ### Version of Immich Mobile App N/A ### Platform with the issue - [ ] Server - [X] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash 1.From my PR add `console.log($isViewingAssetStoreState)` in asset-grid.svelte line 75 2.Navigate to the Photos page, then proceed to any other page, and finally return to the Photos page. 3.A new instance of isViewingAssetStoreState should have been created,resulting in multiple console logs of the variable. But only one ... ``` ### Additional information _No response_
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1058
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?