immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4665] [MERGED] refactor: run dev-down on unclean dev-new exit #10472

New Issue
Closed
opened 2026-02-05 14:22:32 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:32 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4665
Author: @Wingysam
Created: 10/27/2023
Status: ✅ Merged
Merged: 10/27/2023
Merged by: @alextran1502

Base: main ← Head: makefile-dc-down

📝 Commits (1)

  • 354abfd run dev-down on unclean dev-new exit

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Makefile (+1 -1)

📄 Description

Currently, if you ^C the dev server, it exits uncleanly and doesn't clean up the orphaned containers. This means that if you then try to run a production Immich instance, all of the containers hang on "Creating". This PR catches the unclean exit and cleans up properly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4665 **Author:** [@Wingysam](https://github.com/Wingysam) **Created:** 10/27/2023 **Status:** ✅ Merged **Merged:** 10/27/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `makefile-dc-down` --- ### 📝 Commits (1) - [`354abfd`](https://github.com/immich-app/immich/commit/354abfdb3809b01acf053bd1b4b42e2cb3753159) run dev-down on unclean dev-new exit ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) </details> ### 📄 Description Currently, if you ^C the dev server, it exits uncleanly and doesn't clean up the orphaned containers. This means that if you then try to run a production Immich instance, all of the containers hang on "Creating". This PR catches the unclean exit and cleans up properly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:32 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10472
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?