immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4655] [MERGED] feat(server,web,mobile): Add optional password option for share links. #10468

New Issue
Closed
opened 2026-02-05 14:22:28 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:28 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4655
Author: @jarvis2f
Created: 10/26/2023
Status: ✅ Merged
Merged: 10/29/2023
Merged by: @alextran1502

Base: main ← Head: dev/shared-password

📝 Commits (2)

  • de2bed7 feat(server,web,mobile): Add optional password option for share links.
  • 0cbda4e feat(server,web): Update shared-link.controller and page.svelte for improved cookie handling and metadata updates.

📊 Changes

33 files changed (+556 additions, -41 deletions)

View changed files

📝 cli/src/api/open-api/api.ts (+55 -5)
📝 mobile/assets/i18n/en-US.json (+2 -0)
📝 mobile/lib/modules/shared_link/models/shared_link.dart (+8 -1)
📝 mobile/lib/modules/shared_link/services/shared_link.service.dart (+5 -0)
📝 mobile/lib/modules/shared_link/views/shared_link_edit_page.dart (+43 -1)
📝 mobile/openapi/doc/SharedLinkApi.md (+6 -2)
📝 mobile/openapi/doc/SharedLinkCreateDto.md (+1 -0)
📝 mobile/openapi/doc/SharedLinkEditDto.md (+1 -0)
📝 mobile/openapi/doc/SharedLinkResponseDto.md (+2 -0)
📝 mobile/openapi/lib/api/shared_link_api.dart (+17 -3)
📝 mobile/openapi/lib/model/shared_link_create_dto.dart (+18 -1)
📝 mobile/openapi/lib/model/shared_link_edit_dto.dart (+18 -1)
📝 mobile/openapi/lib/model/shared_link_response_dto.dart (+24 -1)
📝 mobile/openapi/test/shared_link_api_test.dart (+1 -1)
📝 mobile/openapi/test/shared_link_create_dto_test.dart (+5 -0)
📝 mobile/openapi/test/shared_link_edit_dto_test.dart (+5 -0)
📝 mobile/openapi/test/shared_link_response_dto_test.dart (+10 -0)
📝 server/immich-openapi-specs.json (+32 -0)
📝 server/src/domain/auth/auth.constant.ts (+1 -0)
📝 server/src/domain/shared-link/shared-link-response.dto.ts (+4 -0)

...and 13 more files

📄 Description

Introduction

This Pull Request aims to introduce password protection for shared links. In this Pull Request, I have implemented the following functionalities:

  • An option to use a password when creating shared links in both web and mobile applications.
  • A prompt for users to enter the password when attempting to access a password-protected shared link through the web application.

Testing

I have added new test cases to ensure the correct functioning of these changes. I have manually tested these changes in both locally environments, everything is running well.

Screenshots

image image image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4655 **Author:** [@jarvis2f](https://github.com/jarvis2f) **Created:** 10/26/2023 **Status:** ✅ Merged **Merged:** 10/29/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `dev/shared-password` --- ### 📝 Commits (2) - [`de2bed7`](https://github.com/immich-app/immich/commit/de2bed771650b2a07b454b53ae355122ee701f4f) feat(server,web,mobile): Add optional password option for share links. - [`0cbda4e`](https://github.com/immich-app/immich/commit/0cbda4e8dd4da55590da6b204c6086a3eaa924fd) feat(server,web): Update shared-link.controller and page.svelte for improved cookie handling and metadata updates. ### 📊 Changes **33 files changed** (+556 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `cli/src/api/open-api/api.ts` (+55 -5) 📝 `mobile/assets/i18n/en-US.json` (+2 -0) 📝 `mobile/lib/modules/shared_link/models/shared_link.dart` (+8 -1) 📝 `mobile/lib/modules/shared_link/services/shared_link.service.dart` (+5 -0) 📝 `mobile/lib/modules/shared_link/views/shared_link_edit_page.dart` (+43 -1) 📝 `mobile/openapi/doc/SharedLinkApi.md` (+6 -2) 📝 `mobile/openapi/doc/SharedLinkCreateDto.md` (+1 -0) 📝 `mobile/openapi/doc/SharedLinkEditDto.md` (+1 -0) 📝 `mobile/openapi/doc/SharedLinkResponseDto.md` (+2 -0) 📝 `mobile/openapi/lib/api/shared_link_api.dart` (+17 -3) 📝 `mobile/openapi/lib/model/shared_link_create_dto.dart` (+18 -1) 📝 `mobile/openapi/lib/model/shared_link_edit_dto.dart` (+18 -1) 📝 `mobile/openapi/lib/model/shared_link_response_dto.dart` (+24 -1) 📝 `mobile/openapi/test/shared_link_api_test.dart` (+1 -1) 📝 `mobile/openapi/test/shared_link_create_dto_test.dart` (+5 -0) 📝 `mobile/openapi/test/shared_link_edit_dto_test.dart` (+5 -0) 📝 `mobile/openapi/test/shared_link_response_dto_test.dart` (+10 -0) 📝 `server/immich-openapi-specs.json` (+32 -0) 📝 `server/src/domain/auth/auth.constant.ts` (+1 -0) 📝 `server/src/domain/shared-link/shared-link-response.dto.ts` (+4 -0) _...and 13 more files_ </details> ### 📄 Description ## Introduction This Pull Request aims to introduce password protection for shared links. In this Pull Request, I have implemented the following functionalities: - An option to use a password when creating shared links in both web and mobile applications. - A prompt for users to enter the password when attempting to access a password-protected shared link through the web application. ## Testing I have added new test cases to ensure the correct functioning of these changes. I have manually tested these changes in both locally environments, everything is running well. ## Screenshots <img width="539" alt="image" src="https://github.com/immich-app/immich/assets/137974272/566d70dc-e246-4413-882c-ad9d269d2a18"> <img width="1497" alt="image" src="https://github.com/immich-app/immich/assets/137974272/60881441-9e44-47fe-8941-bb983bdf1d7a"> <img width="369" alt="image" src="https://github.com/immich-app/immich/assets/137974272/2d314294-296c-4181-ba9b-a297d158122a"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:28 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10468
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?