immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4632] [MERGED] fix(web,server): web socket auth (for web) #10455

New Issue
Closed
opened 2026-02-05 14:22:16 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:22:16 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4632
Author: @jrasm91
Created: 10/25/2023
Status: ✅ Merged
Merged: 10/25/2023
Merged by: @jrasm91

Base: main ← Head: fix/websocket-auth

📝 Commits (1)

  • e675aff fix(web,server): web socket auth (for web)

📊 Changes

5 files changed (+39 additions, -24 deletions)

View changed files

📝 server/src/domain/auth/auth.service.ts (+1 -1)
📝 server/src/immich/app.guard.ts (+0 -5)
📝 server/src/infra/repositories/communication.repository.ts (+7 -11)
📝 web/src/lib/stores/websocket.ts (+15 -4)
📝 web/src/routes/+layout.svelte (+16 -3)

📄 Description

Fixes #4521

The websocket connection requires authentication, so only open a connection after loggin in and disconnect after logging out.

Login and logout is determined by navigating to/from routes that start with `/auth*

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4632 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 10/25/2023 **Status:** ✅ Merged **Merged:** 10/25/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/websocket-auth` --- ### 📝 Commits (1) - [`e675aff`](https://github.com/immich-app/immich/commit/e675aff5d85d8acb28c722eaf5cf0241774748c3) fix(web,server): web socket auth (for web) ### 📊 Changes **5 files changed** (+39 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/auth/auth.service.ts` (+1 -1) 📝 `server/src/immich/app.guard.ts` (+0 -5) 📝 `server/src/infra/repositories/communication.repository.ts` (+7 -11) 📝 `web/src/lib/stores/websocket.ts` (+15 -4) 📝 `web/src/routes/+layout.svelte` (+16 -3) </details> ### 📄 Description Fixes #4521 The websocket connection requires authentication, so only open a connection after loggin in and disconnect after logging out. Login and logout is determined by navigating to/from routes that start with `/auth* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:22:16 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?