immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4575] [MERGED] fix(web): fix #4574 link button + improves accessibility #10427

New Issue
Closed
opened 2026-02-05 14:21:44 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:21:44 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4575
Author: @BogdanCerovac
Created: 10/21/2023
Status: ✅ Merged
Merged: 10/25/2023
Merged by: @jrasm91

Base: main ← Head: 4574-link-button-fix

📝 Commits (7)

  • 714f8fe Fixed semantic problem in navigation-bar.svelte
  • d097dcf Reintroduced styling for navigation-bar.svelte
  • 884e7c1 Horizontal rule set as decoration in navigation-bar.svelte
  • 4b4002b aria-current added as an assistive technology indication for current page
  • 7121068 Temporary fix for accessibility name of the link when SVG replaces text
  • ccbc70b fix(web): horizontal rule replaced with div
  • a49b4dc chore: format

📊 Changes

1 file changed (+18 additions, -13 deletions)

View changed files

📝 web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte (+18 -13)

📄 Description

Button in a link fixed,
horizontal rule is decorative here
and aria-current="page" informs screen-readers that user is on that page when focusing on the link.

fixes #4574

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4575 **Author:** [@BogdanCerovac](https://github.com/BogdanCerovac) **Created:** 10/21/2023 **Status:** ✅ Merged **Merged:** 10/25/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `4574-link-button-fix` --- ### 📝 Commits (7) - [`714f8fe`](https://github.com/immich-app/immich/commit/714f8fe4486f8985fca51ed3e94192a5b5d0c424) Fixed semantic problem in navigation-bar.svelte - [`d097dcf`](https://github.com/immich-app/immich/commit/d097dcfa11074d4897dc29d441160dc258cf11ee) Reintroduced styling for navigation-bar.svelte - [`884e7c1`](https://github.com/immich-app/immich/commit/884e7c147e64f73e6a07f5f1a5c4360c4a67e8d0) Horizontal rule set as decoration in navigation-bar.svelte - [`4b4002b`](https://github.com/immich-app/immich/commit/4b4002bc8c084df5bb9dd1ff6dcf2d8d8ff87674) aria-current added as an assistive technology indication for current page - [`7121068`](https://github.com/immich-app/immich/commit/71210688bb524739bc46fd16960a5f79d9d97ad6) Temporary fix for accessibility name of the link when SVG replaces text - [`ccbc70b`](https://github.com/immich-app/immich/commit/ccbc70bbd740932bccb9f3f8e989435ad5665d9f) fix(web): horizontal rule replaced with div - [`a49b4dc`](https://github.com/immich-app/immich/commit/a49b4dcc29bb95bf46cc82838caf91224cc79f86) chore: format ### 📊 Changes **1 file changed** (+18 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte` (+18 -13) </details> ### 📄 Description Button in a link fixed, horizontal rule is decorative here and `aria-current="page"` informs screen-readers that user is on that page when focusing on the link. fixes #4574 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:21:44 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?