immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4522] [MERGED] fix(web): Prevents nav loop from person->album->albums #10413

New Issue
Closed
opened 2026-02-05 14:21:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:21:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4522
Author: @sellnat77
Created: 10/18/2023
Status: ✅ Merged
Merged: 10/19/2023
Merged by: @alextran1502

Base: main ← Head: 3820-navLoop

📝 Commits (1)

  • 126d5bd fix(web): Prevents nav loop from person->album->albums

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 web/src/routes/(user)/albums/[albumId]/+page.svelte (+1 -1)

📄 Description

Description

  • If the from is the person detail when getting back to the album overview, set backUrl to albums page

Fixes #3820

How Has This Been Tested?

1. Go to album
2. Click on asset with recognized face
3. Click on face in asset info panel
4. Navigate back from face overview clicking the "back" arrow
5. Try to navigate back (out of album) once more
6. You're back at the face overview

After running the above, navigation ends up at the albums overview page instead of a nav loop

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4522 **Author:** [@sellnat77](https://github.com/sellnat77) **Created:** 10/18/2023 **Status:** ✅ Merged **Merged:** 10/19/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `3820-navLoop` --- ### 📝 Commits (1) - [`126d5bd`](https://github.com/immich-app/immich/commit/126d5bd87d3996c132e83c49ba6a917da7befa66) fix(web): Prevents nav loop from person->album->albums ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/src/routes/(user)/albums/[albumId]/+page.svelte` (+1 -1) </details> ### 📄 Description ## Description - If the `from` is the person detail when getting back to the album overview, set backUrl to albums page Fixes #3820 ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> ``` 1. Go to album 2. Click on asset with recognized face 3. Click on face in asset info panel 4. Navigate back from face overview clicking the "back" arrow 5. Try to navigate back (out of album) once more 6. You're back at the face overview After running the above, navigation ends up at the albums overview page instead of a nav loop ``` ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:21:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10413
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?