immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4433] [MERGED] fix(server,cli): don't float promises #10378

New Issue
Closed
opened 2026-02-05 14:20:47 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:20:47 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4433
Author: @etnoy
Created: 10/11/2023
Status: ✅ Merged
Merged: 10/13/2023
Merged by: @jrasm91

Base: main ← Head: fix/dont-float-promises

📝 Commits (5)

📊 Changes

13 files changed (+41 additions, -43 deletions)

View changed files

📝 cli/.eslintrc.js (+1 -0)
📝 cli/src/index.ts (+8 -8)
📝 cli/src/services/session.service.spec.ts (+1 -1)
📝 cli/src/services/session.service.ts (+8 -1)
📝 cli/src/services/upload.service.spec.ts (+4 -15)
📝 cli/src/services/upload.service.ts (+3 -3)
📝 server/.eslintrc.js (+1 -0)
📝 server/src/domain/asset/asset.service.ts (+1 -1)
📝 server/src/domain/search/search.service.spec.ts (+6 -6)
📝 server/src/immich/app.module.ts (+2 -2)
📝 server/src/infra/repositories/communication.repository.ts (+3 -3)
📝 server/src/main.ts (+1 -1)
📝 server/src/microservices/app.service.ts (+2 -2)

📄 Description

Should this be done on the web, too?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4433 **Author:** [@etnoy](https://github.com/etnoy) **Created:** 10/11/2023 **Status:** ✅ Merged **Merged:** 10/13/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/dont-float-promises` --- ### 📝 Commits (5) - [`e6b6ac8`](https://github.com/immich-app/immich/commit/e6b6ac8ff8026f22ada686f61db1b02b538127a1) fix: don't allow floating promises - [`f26e4d1`](https://github.com/immich-app/immich/commit/f26e4d1ea1e0a499ac8866e415784027c8b8a093) fix: await all promises - [`5056687`](https://github.com/immich-app/immich/commit/505668756e7e50ea8ed1c65ced59895393f982c5) fix: download archives - [`d4b695a`](https://github.com/immich-app/immich/commit/d4b695a535ae8391351fa65e3cbf4d002760330d) fix cli tests - [`94def50`](https://github.com/immich-app/immich/commit/94def504262fd59578846eff3ba613c6f2b180f9) fix: skip web ### 📊 Changes **13 files changed** (+41 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `cli/.eslintrc.js` (+1 -0) 📝 `cli/src/index.ts` (+8 -8) 📝 `cli/src/services/session.service.spec.ts` (+1 -1) 📝 `cli/src/services/session.service.ts` (+8 -1) 📝 `cli/src/services/upload.service.spec.ts` (+4 -15) 📝 `cli/src/services/upload.service.ts` (+3 -3) 📝 `server/.eslintrc.js` (+1 -0) 📝 `server/src/domain/asset/asset.service.ts` (+1 -1) 📝 `server/src/domain/search/search.service.spec.ts` (+6 -6) 📝 `server/src/immich/app.module.ts` (+2 -2) 📝 `server/src/infra/repositories/communication.repository.ts` (+3 -3) 📝 `server/src/main.ts` (+1 -1) 📝 `server/src/microservices/app.service.ts` (+2 -2) </details> ### 📄 Description Should this be done on the web, too? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:20:47 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?