immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4358] [MERGED] fix: time buckets #10342

New Issue
Closed
opened 2026-02-05 14:20:09 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:20:09 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4358
Author: @jrasm91
Created: 10/5/2023
Status: ✅ Merged
Merged: 10/6/2023
Merged by: @etnoy

Base: main ← Head: fix/time-buckets

📝 Commits (10+)

📊 Changes

8 files changed (+40 additions, -35 deletions)

View changed files

📝 server/src/domain/metadata/metadata.service.ts (+2 -1)
📝 server/src/infra/entities/asset.entity.ts (+1 -1)
📝 server/src/infra/migrations/1694525143117-AddLocalDateTime.ts (+8 -15)
📝 server/src/infra/repositories/asset.repository.ts (+18 -10)
📝 web/src/lib/components/memory-page/memory-viewer.svelte (+2 -1)
📝 web/src/lib/components/photos-page/asset-date-group.svelte (+2 -3)
📝 web/src/lib/components/shared-components/scrollbar/scrollbar.svelte (+4 -3)
📝 web/src/lib/utils/timeline-util.ts (+3 -1)

📄 Description

Fixes #3616

Basically will work the same way as before, but now, after running a migration and metadata extraction can use the "local time" instead. Changed the implementation to use a date time with time zone and changed both time bucket queries to use localDateTime. This resulted in need to tell the UI to not adjust the time to the local timezone, but instead keep it as is.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4358 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 10/5/2023 **Status:** ✅ Merged **Merged:** 10/6/2023 **Merged by:** [@etnoy](https://github.com/etnoy) **Base:** `main` ← **Head:** `fix/time-buckets` --- ### 📝 Commits (10+) - [`8c10c36`](https://github.com/immich-app/immich/commit/8c10c36ac777620ce18cf5c13a957cba8b59e21a) fix: time buckets - [`de621a3`](https://github.com/immich-app/immich/commit/de621a301e192726aeeacca05d86ffc88c66b3f0) chore: update entity metadata - [`e958878`](https://github.com/immich-app/immich/commit/e958878ebdcb1c44e6bb5c18ae484e9a9e6190de) fix: set correct localDateTime - [`ef3faa0`](https://github.com/immich-app/immich/commit/ef3faa0529f5d5282566949a0f1e03ce3b40f96a) fix: display without timezone shifting - [`6c5dd2d`](https://github.com/immich-app/immich/commit/6c5dd2de17cb49dd75864a4c5b4f947a35a1689a) Merge branch 'main' of https://github.com/immich-app/immich into fix/time-buckets - [`b2ea570`](https://github.com/immich-app/immich/commit/b2ea570d6eddebcc7f8f9093d671734eed617689) Merge branch 'fix/time-buckets' of https://github.com/immich-app/immich into fix/time-buckets - [`12bcb7e`](https://github.com/immich-app/immich/commit/12bcb7e93b4df1331b9e5e59b3eae17a4fe1b636) fix: handle non-utc databases - [`434fe1d`](https://github.com/immich-app/immich/commit/434fe1daa75f67757226d26dc81a4f43f80bb08e) fix: scrollbar - [`c33f9ba`](https://github.com/immich-app/immich/commit/c33f9baa4080c4311f95f4e906d1e867c33af329) docs: comment how buckets are sorted - [`ca4249a`](https://github.com/immich-app/immich/commit/ca4249a768c75894fc1fe980874095c5906b467f) chore: remove test/log ### 📊 Changes **8 files changed** (+40 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/metadata/metadata.service.ts` (+2 -1) 📝 `server/src/infra/entities/asset.entity.ts` (+1 -1) 📝 `server/src/infra/migrations/1694525143117-AddLocalDateTime.ts` (+8 -15) 📝 `server/src/infra/repositories/asset.repository.ts` (+18 -10) 📝 `web/src/lib/components/memory-page/memory-viewer.svelte` (+2 -1) 📝 `web/src/lib/components/photos-page/asset-date-group.svelte` (+2 -3) 📝 `web/src/lib/components/shared-components/scrollbar/scrollbar.svelte` (+4 -3) 📝 `web/src/lib/utils/timeline-util.ts` (+3 -1) </details> ### 📄 Description Fixes #3616 Basically will work the same way as before, but now, after running a migration and metadata extraction can use the "local time" instead. Changed the implementation to use a date time with time zone and changed _both_ time bucket queries to use `localDateTime`. This resulted in need to tell the UI to not adjust the time to the local timezone, but instead keep it as is. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:20:09 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?