immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-02-05 08:41:28 +03:00
Code Issues 26 Packages Projects Releases 10 Wiki Activity

albums should use smaller thumbnails #1032

New Issue
Closed
opened 2026-02-05 00:06:47 +03:00 by OVERLORD · 7 comments
OVERLORD commented 2026-02-05 00:06:47 +03:00
Owner
Copy Link

Originally created by @uhthomas on GitHub (Jun 29, 2023).

Originally assigned to: @jrasm91 on GitHub.

The bug

Albums use jpeg thumbnails, which for some reason are ginormous compared to webp. There is no need to use a thumbnail with a resolution of 2161x1440 for albums.

86562f256f/server/src/domain/media/media.constant.ts (L1-L2)

Related? #2749

The OS that Immich Server is running on

N/A

Version of Immich Server

v1.64.0

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

N/A

Additional information

No response

Originally created by @uhthomas on GitHub (Jun 29, 2023). Originally assigned to: @jrasm91 on GitHub. ### The bug Albums use jpeg thumbnails, which for some reason are ginormous compared to webp. There is no need to use a thumbnail with a resolution of 2161x1440 for albums. https://github.com/immich-app/immich/blob/86562f256f715154e852e0113a05f6a062c858c0/server/src/domain/media/media.constant.ts#L1-L2 Related? #2749 ### The OS that Immich Server is running on N/A ### Version of Immich Server v1.64.0 ### Version of Immich Mobile App N/A ### Platform with the issue - [X] Server - [ ] Web - [ ] Mobile ### Your docker-compose.yml content ```YAML N/A ``` ### Your .env content ```Shell N/A ``` ### Reproduction steps ```bash N/A ``` ### Additional information _No response_
OVERLORD commented 2026-02-05 00:06:56 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Aug 27, 2023):

Albums use the asset grid component now which uses webp thumbnails like the main timeline. Unless I am misunderstanding the issue this has been fixed now.

@jrasm91 commented on GitHub (Aug 27, 2023): Albums use the asset grid component now which uses webp thumbnails like the main timeline. Unless I am misunderstanding the issue this has been fixed now.
OVERLORD commented 2026-02-05 00:06:58 +03:00
Author
Owner
Copy Link

@uhthomas commented on GitHub (Aug 27, 2023):

Albums use the asset grid component now which uses webp thumbnails like the main timeline. Unless I am misunderstanding the issue this has been fixed now.

This isn't to do with the album view, but the actual album thumbnail itself.

@uhthomas commented on GitHub (Aug 27, 2023): > Albums use the asset grid component now which uses webp thumbnails like the main timeline. Unless I am misunderstanding the issue this has been fixed now. This isn't to do with the album view, but the actual album thumbnail itself.
OVERLORD commented 2026-02-05 00:07:02 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Aug 28, 2023):

Ok, might be good to update the issue to be more clear/specific in that case.

The album view loads webp initially and then lazy loads the higher jpegs afterwards, which I think is fine. They look better imo.

@jrasm91 commented on GitHub (Aug 28, 2023): Ok, might be good to update the issue to be more clear/specific in that case. The album view loads webp initially and then lazy loads the higher jpegs afterwards, which I think is fine. They look better imo.
OVERLORD commented 2026-02-05 00:07:05 +03:00
Author
Owner
Copy Link

@uhthomas commented on GitHub (Aug 28, 2023):

To make sure we're on the same page - this view, right? There is no need to use a 2k image for a 300px element.

Screenshot 2023-08-27 at 23 32 16
@uhthomas commented on GitHub (Aug 28, 2023): To make sure we're on the same page - this view, right? There is no need to use a 2k image for a 300px element. <img width="993" alt="Screenshot 2023-08-27 at 23 32 16" src="https://github.com/immich-app/immich/assets/9749173/add1b3fa-3002-4588-a2bb-1939e4a6e470">
OVERLORD commented 2026-02-05 00:07:08 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Aug 28, 2023):

High res ones are lazy loaded, which is fine imo.

https://github.com/immich-app/immich/blob/main/web/src/lib/components/album-page/album-card.svelte#L17-L42

@jrasm91 commented on GitHub (Aug 28, 2023): High res ones are lazy loaded, which is fine imo. https://github.com/immich-app/immich/blob/main/web/src/lib/components/album-page/album-card.svelte#L17-L42
OVERLORD commented 2026-02-05 00:07:13 +03:00
Author
Owner
Copy Link

@uhthomas commented on GitHub (Aug 28, 2023):

I'm not so sure. It's not free to do this - it's additional bandwidth and has a performance impact on some platforms. We should really be displaying a more appropriate size like 300px for a 300px element rather than 2k, which is absurdly huge.

@uhthomas commented on GitHub (Aug 28, 2023): I'm not so sure. It's not free to do this - it's additional bandwidth and has a performance impact on some platforms. We should really be displaying a more appropriate size like 300px for a 300px element rather than 2k, which is absurdly huge.
OVERLORD commented 2026-02-05 00:07:17 +03:00
Author
Owner
Copy Link

@jrasm91 commented on GitHub (Aug 28, 2023):

You can ask @alextran1502 if he wants to remove the code to load the jpegs. It is working as intended and designed regardless if you think it is correct or not. I don't have an opinion if we keep the high quality thumbnails or only use the webp ones for what it is worth. The whole thumbnail solution will probably need to be revamped in the future, but that is an entirely separate issue and discussion, and certainly not something best described as a bug. There is no action item to take here unless we decide to revert the code that loads the high resolution thumbnail. That was added before my time and I am unaware of the circumstances and thought process around why it was added.

@jrasm91 commented on GitHub (Aug 28, 2023): You can ask @alextran1502 if he wants to remove the code to load the jpegs. It is working as intended and designed regardless if you think it is correct or not. I don't have an opinion if we keep the high quality thumbnails or only use the webp ones for what it is worth. The whole thumbnail solution will probably need to be revamped in the future, but that is an entirely separate issue and discussion, and certainly not something best described as a bug. There is no action item to take here unless we decide to revert the code that loads the high resolution thumbnail. That was added before my time and I am unaware of the circumstances and thought process around why it was added.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
documentation
external-library
format
good first issue
needs-answer
nice to have
sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#1032
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?