immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4258] [MERGED] fix(server): always disable two-pass mode for video thumbnails #10306

New Issue
Closed
opened 2026-02-05 14:19:30 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:19:30 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4258
Author: @mertalev
Created: 9/28/2023
Status: ✅ Merged
Merged: 9/28/2023
Merged by: @jrasm91

Base: main ← Head: fix/thumbnail-two-pass

📝 Commits (3)

  • 29beee5 always disable two-pass mode for thumbnails
  • 49a5b15 add regression test
  • 7820e6a added bitrate constraint to config mock

📊 Changes

2 files changed (+28 additions, -0 deletions)

View changed files

📝 server/src/domain/media/media.service.spec.ts (+24 -0)
📝 server/src/domain/media/media.util.ts (+4 -0)

📄 Description

Description

This is a fix for a regression where video thumbnails can be called with two-pass mode, leading to errors. There's no point in two-pass mode here so it should always be set to false for thumbnails.

Fixes #4205

How Has This Been Tested?

I added a regression test that fails on main, but passes in this branch.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4258 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 9/28/2023 **Status:** ✅ Merged **Merged:** 9/28/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/thumbnail-two-pass` --- ### 📝 Commits (3) - [`29beee5`](https://github.com/immich-app/immich/commit/29beee51655c5a3438aa75a2e7f6119d1f386b0c) always disable two-pass mode for thumbnails - [`49a5b15`](https://github.com/immich-app/immich/commit/49a5b15642c6a3e2619910210ce87279022c81f1) add regression test - [`7820e6a`](https://github.com/immich-app/immich/commit/7820e6a525b880d1406b300d3390183be7349703) added bitrate constraint to config mock ### 📊 Changes **2 files changed** (+28 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/media/media.service.spec.ts` (+24 -0) 📝 `server/src/domain/media/media.util.ts` (+4 -0) </details> ### 📄 Description ## Description This is a fix for a regression where video thumbnails can be called with two-pass mode, leading to errors. There's no point in two-pass mode here so it should always be set to false for thumbnails. Fixes #4205 ## How Has This Been Tested? I added a regression test that fails on main, but passes in this branch. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:19:30 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?