immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4243] [MERGED] refactor(server): move metadata extraction to domain #10301

New Issue
Closed
opened 2026-02-05 14:19:24 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:19:24 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4243
Author: @danieldietzler
Created: 9/26/2023
Status: ✅ Merged
Merged: 9/27/2023
Merged by: @jrasm91

Base: main ← Head: chore/metadata-extraction-to-domain

📝 Commits (4)

  • c064833 use storageRepository in metadata extraction
  • 988a632 move metadata extraction processor to domain
  • fc29878 cleanup infra/domain
  • 5f9bdc5 chore: coverage

📊 Changes

17 files changed (+410 additions, -396 deletions)

View changed files

📝 server/package.json (+1 -1)
➖ server/src/domain/metadata/geocoding.repository.ts (+0 -20)
📝 server/src/domain/metadata/index.ts (+1 -1)
➕ server/src/domain/metadata/metadata.repository.ts (+31 -0)
📝 server/src/domain/metadata/metadata.service.spec.ts (+24 -3)
📝 server/src/domain/metadata/metadata.service.ts (+289 -5)
📝 server/src/domain/storage/storage.repository.ts (+3 -0)
📝 server/src/infra/infra.module.ts (+5 -5)
📝 server/src/infra/repositories/filesystem.provider.ts (+13 -1)
📝 server/src/infra/repositories/index.ts (+1 -1)
📝 server/src/infra/repositories/metadata.repository.ts (+23 -3)
📝 server/src/microservices/app.service.ts (+5 -9)
📝 server/src/microservices/microservices.module.ts (+1 -2)
➖ server/src/microservices/processors/metadata-extraction.processor.ts (+0 -345)
📝 server/test/repositories/index.ts (+1 -0)
➕ server/test/repositories/metadata.repository.mock.ts (+10 -0)
📝 server/test/repositories/storage.repository.mock.ts (+2 -0)

📄 Description

Manually testing this I couldn't find any regressions.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4243 **Author:** [@danieldietzler](https://github.com/danieldietzler) **Created:** 9/26/2023 **Status:** ✅ Merged **Merged:** 9/27/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `chore/metadata-extraction-to-domain` --- ### 📝 Commits (4) - [`c064833`](https://github.com/immich-app/immich/commit/c06483352e16ea0d1b9669c7ce531d8d6c19feea) use storageRepository in metadata extraction - [`988a632`](https://github.com/immich-app/immich/commit/988a6329e060c57cb28ed9963bca891c8af47254) move metadata extraction processor to domain - [`fc29878`](https://github.com/immich-app/immich/commit/fc29878891b8d2128482be221c5d4666ec801959) cleanup infra/domain - [`5f9bdc5`](https://github.com/immich-app/immich/commit/5f9bdc5e32bfb3c44bd333a47398d97eeb44c71b) chore: coverage ### 📊 Changes **17 files changed** (+410 additions, -396 deletions) <details> <summary>View changed files</summary> 📝 `server/package.json` (+1 -1) ➖ `server/src/domain/metadata/geocoding.repository.ts` (+0 -20) 📝 `server/src/domain/metadata/index.ts` (+1 -1) ➕ `server/src/domain/metadata/metadata.repository.ts` (+31 -0) 📝 `server/src/domain/metadata/metadata.service.spec.ts` (+24 -3) 📝 `server/src/domain/metadata/metadata.service.ts` (+289 -5) 📝 `server/src/domain/storage/storage.repository.ts` (+3 -0) 📝 `server/src/infra/infra.module.ts` (+5 -5) 📝 `server/src/infra/repositories/filesystem.provider.ts` (+13 -1) 📝 `server/src/infra/repositories/index.ts` (+1 -1) 📝 `server/src/infra/repositories/metadata.repository.ts` (+23 -3) 📝 `server/src/microservices/app.service.ts` (+5 -9) 📝 `server/src/microservices/microservices.module.ts` (+1 -2) ➖ `server/src/microservices/processors/metadata-extraction.processor.ts` (+0 -345) 📝 `server/test/repositories/index.ts` (+1 -0) ➕ `server/test/repositories/metadata.repository.mock.ts` (+10 -0) 📝 `server/test/repositories/storage.repository.mock.ts` (+2 -0) </details> ### 📄 Description Manually testing this I couldn't find any regressions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:19:24 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10301
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?