immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #4219] [MERGED] chore(web): remove upload preview #10285

New Issue
Closed
opened 2026-02-05 14:19:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:19:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4219
Author: @jrasm91
Created: 9/25/2023
Status: ✅ Merged
Merged: 9/25/2023
Merged by: @alextran1502

Base: main ← Head: chore/remove-upload-preview

📝 Commits (1)

  • a5d1571 chore(web): remove upload preview

📊 Changes

1 file changed (+3 additions, -24 deletions)

View changed files

📝 web/src/lib/components/shared-components/upload-asset-preview.svelte (+3 -24)

📄 Description

When testing the upload PR (#3850), I temporarily disabled the asset preview, since it was causing me trouble while testing. Looks like that code got checked in by accident (|| true) and nobody has complained 😛. Especially when assets are uploaded quickly, it only causes problems, so this PR just removes it officially.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4219 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 9/25/2023 **Status:** ✅ Merged **Merged:** 9/25/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `chore/remove-upload-preview` --- ### 📝 Commits (1) - [`a5d1571`](https://github.com/immich-app/immich/commit/a5d1571efe224df293a027ad3496c64b7ea561e2) chore(web): remove upload preview ### 📊 Changes **1 file changed** (+3 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/shared-components/upload-asset-preview.svelte` (+3 -24) </details> ### 📄 Description When testing the upload PR (#3850), I temporarily disabled the asset preview, since it was causing me trouble while testing. Looks like that code got checked in by accident (`|| true`) and nobody has complained :stuck_out_tongue:. Especially when assets are uploaded quickly, it only causes problems, so this PR just removes it officially. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:19:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10285
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?