immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4201] [MERGED] fix(server): Random assets endpoint return always n assets if available #10282

New Issue
Closed
opened 2026-02-05 14:19:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:19:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4201
Author: @danieldietzler
Created: 9/24/2023
Status: ✅ Merged
Merged: 9/24/2023
Merged by: @alextran1502

Base: main ← Head: fix/random-assets

📝 Commits (1)

  • 90f4800 fix random returning less than count assets

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 server/src/infra/repositories/asset.repository.ts (+1 -1)

📄 Description

Before, the query could have started choosing assets at an index > total - n, so that it couldn't return all n assets, although there are n assets available in the library

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4201 **Author:** [@danieldietzler](https://github.com/danieldietzler) **Created:** 9/24/2023 **Status:** ✅ Merged **Merged:** 9/24/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/random-assets` --- ### 📝 Commits (1) - [`90f4800`](https://github.com/immich-app/immich/commit/90f4800753af5ce43c3639e8082e2e7a31865bf6) fix random returning less than count assets ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `server/src/infra/repositories/asset.repository.ts` (+1 -1) </details> ### 📄 Description Before, the query could have started choosing assets at an index > `total - n`, so that it couldn't return all n assets, although there are n assets available in the library --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:19:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10282
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?