immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #4138] [MERGED] chore(server): Use access core for person permissions #10261

New Issue
Closed
opened 2026-02-05 14:18:41 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:18:41 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/4138
Author: @danieldietzler
Created: 9/18/2023
Status: ✅ Merged
Merged: 9/19/2023
Merged by: @jrasm91

Base: main ← Head: chore/refactor-person-repo

📝 Commits (6)

  • 30ac8a8 use access core for all person methods
  • 64d4a3b minor fixes, feedback
  • 5c71486 reorder assignments
  • 4bd2bf0 remove unnecessary permission requirement
  • 831943d unify naming of tests
  • 1a02b93 reorder variables

📊 Changes

8 files changed (+169 additions, -27 deletions)

View changed files

📝 server/src/domain/access/access.core.ts (+13 -0)
📝 server/src/domain/access/access.repository.ts (+4 -0)
📝 server/src/domain/person/person.repository.ts (+2 -2)
📝 server/src/domain/person/person.service.spec.ts (+103 -10)
📝 server/src/domain/person/person.service.ts (+26 -10)
📝 server/src/infra/repositories/access.repository.ts (+13 -1)
📝 server/src/infra/repositories/person.repository.ts (+3 -4)
📝 server/test/repositories/access.repository.mock.ts (+5 -0)

📄 Description

Migrate all person service methods to use access core instead of making their own queries on the person table

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/4138 **Author:** [@danieldietzler](https://github.com/danieldietzler) **Created:** 9/18/2023 **Status:** ✅ Merged **Merged:** 9/19/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `chore/refactor-person-repo` --- ### 📝 Commits (6) - [`30ac8a8`](https://github.com/immich-app/immich/commit/30ac8a86a885430319aa576b1f626cc17d08b1a5) use access core for all person methods - [`64d4a3b`](https://github.com/immich-app/immich/commit/64d4a3b1d0af73bd0ff1f70e50dcb7f0391b18a0) minor fixes, feedback - [`5c71486`](https://github.com/immich-app/immich/commit/5c71486030f7728bca35ffd5376898b70beda6fc) reorder assignments - [`4bd2bf0`](https://github.com/immich-app/immich/commit/4bd2bf06b08d2805821c92d954fb6f267d132912) remove unnecessary permission requirement - [`831943d`](https://github.com/immich-app/immich/commit/831943de1866ae477563a277c89e0235504ee762) unify naming of tests - [`1a02b93`](https://github.com/immich-app/immich/commit/1a02b9380745463ea321eab4af603cc8a221a407) reorder variables ### 📊 Changes **8 files changed** (+169 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/access/access.core.ts` (+13 -0) 📝 `server/src/domain/access/access.repository.ts` (+4 -0) 📝 `server/src/domain/person/person.repository.ts` (+2 -2) 📝 `server/src/domain/person/person.service.spec.ts` (+103 -10) 📝 `server/src/domain/person/person.service.ts` (+26 -10) 📝 `server/src/infra/repositories/access.repository.ts` (+13 -1) 📝 `server/src/infra/repositories/person.repository.ts` (+3 -4) 📝 `server/test/repositories/access.repository.mock.ts` (+5 -0) </details> ### 📄 Description Migrate all person service methods to use access core instead of making their own queries on the person table --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:18:41 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10261
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?