immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3957] [MERGED] fix(mobile): map markers not loading with int coordinates #10177

New Issue
Closed
opened 2026-02-05 14:17:14 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:17:14 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3957
Author: @shenlong-tanwen
Created: 9/3/2023
Status: ✅ Merged
Merged: 9/5/2023
Merged by: @alextran1502

Base: main ← Head: fix/map-improvements

📝 Commits (10+)

  • 4528bea fix(mobile): increase zoom-level for map zoom to asset
  • 79bbfc7 refactor(mobile): map-view - rename lastAssetOffsetInSheet
  • 91d20ec Workaround OpenAPI Dart generator bug
  • 2ac4aca fix(mobile): map - increase appbar top padding
  • c98a996 fix(mobile): navigation bar overlapping map bottom sheet
  • 108a365 fix(mobile): map - do not animate the drag handle of bottom sheet on scroll
  • f49b9d3 fix(mobile): F-Droid build failure due to map view
  • 68e6528 fix(mobile): remove jank on map asset marker update
  • 1769ab7 fix(mobile): map view app-bar padding is made dynamic
  • 0c96396 fix(mobile): reduce debounce time in bottom sheet asset scroll

📊 Changes

10 files changed (+178 additions, -120 deletions)

View changed files

📝 mobile/android/app/build.gradle (+5 -0)
📝 mobile/android/app/src/main/AndroidManifest.xml (+0 -1)
📝 mobile/lib/modules/map/ui/asset_marker_icon.dart (+2 -2)
📝 mobile/lib/modules/map/ui/map_page_app_bar.dart (+1 -1)
📝 mobile/lib/modules/map/ui/map_page_bottom_sheet.dart (+120 -108)
📝 mobile/lib/modules/map/views/map_page.dart (+13 -4)
📝 mobile/openapi/lib/model/map_marker_response_dto.dart (+2 -2)
📝 mobile/pubspec.yaml (+9 -0)
📝 server/openapi-generator/templates/mobile/serialization/native/native_class.mustache (+5 -0)
📝 server/openapi-generator/templates/mobile/serialization/native/native_class.mustache.patch (+21 -2)

📄 Description

Changes made in the PR

  • Fixes #3936 by padding the bottom-sheet to the size of the bottom nav bar in android devices. Total height of the bottom-sheet drag handle is also reduced
  • Fixes #3935 by handling double values appropriately by patching the openapi-generator (Thanks to @daniele-athome for the patch to the generator)
  • Map "zoom to asset" zoom level is set to 16 since the previous level was too zoomed out for this feature
  • Map view app bar top padding is made dynamic based on media query to make it not overlap with the android's notification bar
  • Map view bottom sheet drag handle's physics is set to Clamp to prevent it from animating beyond constraints on scroll
  • AssetMarkerIcon used to display markers is updated to reduce jank on marker update
  • Debounce duration is reduced in Map view bottom sheet to update markers often on bottom sheet album grid scroll
  • Overrides are added for the geolocator plugin in pubspec.yaml and build.gradle. This is to be commented out in the F-Droid build generation and so, the GSM free version of the plugin will only be used in the app published through F-Droid.

⚠️ Zoom to location feature might not work properly in the GSM free version due to the plugin not depending on google for location service. Location of the users might not be fetched consistently but other features of the map view works properly though. If that feature is required, we can ask the users to use the playstore version or the app from github releases. In future, we can even detect the build type during runtime and show an alert stating the same

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3957 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 9/3/2023 **Status:** ✅ Merged **Merged:** 9/5/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/map-improvements` --- ### 📝 Commits (10+) - [`4528bea`](https://github.com/immich-app/immich/commit/4528beafab2b5fe91e2601f4ecad926cd9c9177d) fix(mobile): increase zoom-level for map zoom to asset - [`79bbfc7`](https://github.com/immich-app/immich/commit/79bbfc79b805cfd1a95330285e33300b3c89b07d) refactor(mobile): map-view - rename lastAssetOffsetInSheet - [`91d20ec`](https://github.com/immich-app/immich/commit/91d20ecc1d8ed5eeaecc769c3a6d2ea4cf39148c) Workaround OpenAPI Dart generator bug - [`2ac4aca`](https://github.com/immich-app/immich/commit/2ac4aca8bb73745f66280083bbb1736077d494df) fix(mobile): map - increase appbar top padding - [`c98a996`](https://github.com/immich-app/immich/commit/c98a996ecaeac7b8d76ec3a5f2b8093f56f51801) fix(mobile): navigation bar overlapping map bottom sheet - [`108a365`](https://github.com/immich-app/immich/commit/108a365aff7db33b70fb234ed4b0e91d07c1a775) fix(mobile): map - do not animate the drag handle of bottom sheet on scroll - [`f49b9d3`](https://github.com/immich-app/immich/commit/f49b9d3ddf9378ed178682d552bcba4da214914e) fix(mobile): F-Droid build failure due to map view - [`68e6528`](https://github.com/immich-app/immich/commit/68e652893792ac10aefb092c6393a830587bb109) fix(mobile): remove jank on map asset marker update - [`1769ab7`](https://github.com/immich-app/immich/commit/1769ab70941aa0400f791dd56d04fdb6cebb5c27) fix(mobile): map view app-bar padding is made dynamic - [`0c96396`](https://github.com/immich-app/immich/commit/0c963961c7b3a6fabed1e6a5e15f6922adf97c0d) fix(mobile): reduce debounce time in bottom sheet asset scroll ### 📊 Changes **10 files changed** (+178 additions, -120 deletions) <details> <summary>View changed files</summary> 📝 `mobile/android/app/build.gradle` (+5 -0) 📝 `mobile/android/app/src/main/AndroidManifest.xml` (+0 -1) 📝 `mobile/lib/modules/map/ui/asset_marker_icon.dart` (+2 -2) 📝 `mobile/lib/modules/map/ui/map_page_app_bar.dart` (+1 -1) 📝 `mobile/lib/modules/map/ui/map_page_bottom_sheet.dart` (+120 -108) 📝 `mobile/lib/modules/map/views/map_page.dart` (+13 -4) 📝 `mobile/openapi/lib/model/map_marker_response_dto.dart` (+2 -2) 📝 `mobile/pubspec.yaml` (+9 -0) 📝 `server/openapi-generator/templates/mobile/serialization/native/native_class.mustache` (+5 -0) 📝 `server/openapi-generator/templates/mobile/serialization/native/native_class.mustache.patch` (+21 -2) </details> ### 📄 Description ### Changes made in the PR - Fixes #3936 by padding the bottom-sheet to the size of the bottom nav bar in android devices. Total height of the bottom-sheet drag handle is also reduced - Fixes #3935 by handling double values appropriately by patching the openapi-generator (Thanks to @daniele-athome for the patch to the generator) - Map "zoom to asset" zoom level is set to 16 since the previous level was too zoomed out for this feature - Map view app bar top padding is made dynamic based on media query to make it not overlap with the android's notification bar - Map view bottom sheet drag handle's physics is set to Clamp to prevent it from animating beyond constraints on scroll - `AssetMarkerIcon` used to display markers is updated to reduce jank on marker update - Debounce duration is reduced in Map view bottom sheet to update markers often on bottom sheet album grid scroll - Overrides are added for the `geolocator` plugin in `pubspec.yaml` and `build.gradle`. This is to be commented out in the F-Droid build generation and so, the GSM free version of the plugin will only be used in the app published through F-Droid. ⚠️ Zoom to location feature might not work properly in the GSM free version due to the plugin not depending on google for location service. Location of the users might not be fetched consistently but other features of the map view works properly though. If that feature is required, we can ask the users to use the playstore version or the app from github releases. In future, we can even detect the build type during runtime and show an alert stating the same --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:17:14 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10177
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?