immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3872] [MERGED] feat(mobile): upload image assets before videos #10139

New Issue
Closed
opened 2026-02-05 14:16:37 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:16:37 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3872
Author: @shenlong-tanwen
Created: 8/26/2023
Status: ✅ Merged
Merged: 8/27/2023
Merged by: @alextran1502

Base: main ← Head: feat/mobile-upload-images-first

📝 Commits (2)

  • 271d169 feat(mobile): upload image assets before videos
  • 66de1c6 mobile: sort by creation date before uploading assets

📊 Changes

1 file changed (+14 additions, -2 deletions)

View changed files

📝 mobile/lib/modules/backup/services/backup.service.dart (+14 -2)

📄 Description

Changes made in this PR:

Asset backup flow is updated to always prefer image files before uploading video files. Mobile device uploads are sequential and so, uploading a huge video file might block the other uploads from getting processed faster. Since most of the times, image assets are smaller than video assets, it makes sense to try to upload them so as to maximize the number of uploads. This is especially useful in iOS if a large video asset gets retried in a loop blocking other smaller image assets from getting uploaded

How was this tested?

The backup service code is common for both background upload and manual asset upload. I've tested the change only with manual upload. Background upload should work properly as well

  • Tried uploading a mix of image and video assets manually and ensured that images are getting uploaded before the video assets are processed.

Feedback required

  • I'm not sure if the current flow of uploading the assets as they come is useful. But if people prefer that, we can have this "image before video" behind a toggle in the backup page?

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3872 **Author:** [@shenlong-tanwen](https://github.com/shenlong-tanwen) **Created:** 8/26/2023 **Status:** ✅ Merged **Merged:** 8/27/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/mobile-upload-images-first` --- ### 📝 Commits (2) - [`271d169`](https://github.com/immich-app/immich/commit/271d169fb4b6f87b09c1458ca715db3980f8bd6c) feat(mobile): upload image assets before videos - [`66de1c6`](https://github.com/immich-app/immich/commit/66de1c6f3f413ba25adf9b70ebf389a10156cb02) mobile: sort by creation date before uploading assets ### 📊 Changes **1 file changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/backup/services/backup.service.dart` (+14 -2) </details> ### 📄 Description ### Changes made in this PR: Asset backup flow is updated to always prefer image files before uploading video files. Mobile device uploads are sequential and so, uploading a huge video file might block the other uploads from getting processed faster. Since most of the times, image assets are smaller than video assets, it makes sense to try to upload them so as to maximize the number of uploads. This is especially useful in iOS if a large video asset gets retried in a loop blocking other smaller image assets from getting uploaded - #3341 ### How was this tested? The backup service code is common for both background upload and manual asset upload. I've tested the change only with manual upload. Background upload should work properly as well - Tried uploading a mix of image and video assets manually and ensured that images are getting uploaded before the video assets are processed. ### Feedback required - I'm not sure if the current flow of uploading the assets as they come is useful. But if people prefer that, we can have this "image before video" behind a toggle in the backup page? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:16:37 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?