immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3772] [MERGED] fix(mobile) Fix ios map launch & Use OSM as map fallback #10109

New Issue
Closed
opened 2026-02-05 14:16:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:16:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3772
Author: @SteffenAuer
Created: 8/18/2023
Status: ✅ Merged
Merged: 8/19/2023
Merged by: @alextran1502

Base: main ← Head: improve-mobile-map-launch

📝 Commits (1)

  • 16baf4e fix ios map launch, use OSM as map fallback, use dates as labels

📊 Changes

1 file changed (+40 additions, -26 deletions)

View changed files

📝 mobile/lib/modules/asset_viewer/ui/exif_bottom_sheet.dart (+40 -26)

📄 Description

I saw the new feature to open the Maps app when tapping on the preview map of an image in the new version. Sadly, it always opened Google Maps in the browser and not the Apple Maps App. This PR:

Screen Recordings

Opening Apple Maps

https://github.com/immich-app/immich/assets/60623116/f055bea6-5504-407d-811c-41bd882952cb

Opening OSM

https://github.com/immich-app/immich/assets/60623116/1ccddb39-e04d-4c8f-a215-e250e2ac0857

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3772 **Author:** [@SteffenAuer](https://github.com/SteffenAuer) **Created:** 8/18/2023 **Status:** ✅ Merged **Merged:** 8/19/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `improve-mobile-map-launch` --- ### 📝 Commits (1) - [`16baf4e`](https://github.com/immich-app/immich/commit/16baf4e8567f485dc150e82f0ef07feadd595439) fix ios map launch, use OSM as map fallback, use dates as labels ### 📊 Changes **1 file changed** (+40 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `mobile/lib/modules/asset_viewer/ui/exif_bottom_sheet.dart` (+40 -26) </details> ### 📄 Description I saw the new feature to open the Maps app when tapping on the preview map of an image in the new version. Sadly, it always opened Google Maps in the browser and not the Apple Maps App. This PR: - (imho) fixes that and on iOS now opens the Maps app - Following the official docs here: https://developer.apple.com/library/archive/featuredarticles/iPhoneURLScheme_Reference/MapLinks/MapLinks.html - Changes the fallback from Google Maps to OSM - Following the docs here: https://wiki.openstreetmap.org/wiki/Browsing#Other_URL_tricks - Changes the "label" that's shown when opening the (Apple/Google) Maps application from the coordinates (which are anyway shown for a pin on the map) to the date & time of the image. ## Screen Recordings ### Opening Apple Maps https://github.com/immich-app/immich/assets/60623116/f055bea6-5504-407d-811c-41bd882952cb ## Opening OSM https://github.com/immich-app/immich/assets/60623116/1ccddb39-e04d-4c8f-a215-e250e2ac0857 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:16:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10109
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?