immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3753] [MERGED] fix(web): escape shortcut #10102

New Issue
Closed
opened 2026-02-05 14:16:02 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:16:02 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3753
Author: @martabal
Created: 8/17/2023
Status: ✅ Merged
Merged: 9/26/2023
Merged by: @jrasm91

Base: main ← Head: fix/escape-shortcut

📝 Commits (3)

📊 Changes

21 files changed (+140 additions, -27 deletions)

View changed files

📝 web/src/lib/components/album-page/edit-description-modal.svelte (+6 -7)
📝 web/src/lib/components/asset-viewer/asset-viewer.svelte (+4 -0)
📝 web/src/lib/components/elements/dropdown.svelte (+1 -1)
📝 web/src/lib/components/map-page/map-settings-modal.svelte (+4 -2)
📝 web/src/lib/components/photos-page/actions/create-shared-link.svelte (+11 -1)
📝 web/src/lib/components/photos-page/actions/delete-assets.svelte (+9 -0)
📝 web/src/lib/components/photos-page/asset-grid.svelte (+2 -2)
📝 web/src/lib/components/shared-components/base-modal.svelte (+1 -0)
📝 web/src/lib/components/shared-components/confirm-dialogue.svelte (+6 -1)
📝 web/src/lib/components/shared-components/context-menu/context-menu.svelte (+1 -0)
📝 web/src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte (+1 -1)
📝 web/src/lib/components/shared-components/full-screen-modal.svelte (+10 -2)
📝 web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte (+5 -1)
📝 web/src/lib/components/shared-components/search-bar/search-bar.svelte (+2 -1)
📝 web/src/lib/components/shared-components/show-shortcuts.svelte (+1 -1)
📝 web/src/lib/utils/click-outside.ts (+2 -1)
📝 web/src/routes/(user)/albums/+page.svelte (+1 -1)
📝 web/src/routes/(user)/albums/[albumId]/+page.svelte (+28 -1)
📝 web/src/routes/(user)/people/[personId]/+page.svelte (+18 -1)
📝 web/src/routes/(user)/photos/+page.svelte (+23 -3)

...and 1 more files

📄 Description

This PR aims to enhance how the 'Escape' key shortcut is handled on the web app.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3753 **Author:** [@martabal](https://github.com/martabal) **Created:** 8/17/2023 **Status:** ✅ Merged **Merged:** 9/26/2023 **Merged by:** [@jrasm91](https://github.com/jrasm91) **Base:** `main` ← **Head:** `fix/escape-shortcut` --- ### 📝 Commits (3) - [`4370faf`](https://github.com/immich-app/immich/commit/4370fafb1c8b96715f0c67f633d658024f31b7b4) fix: escape shortcut - [`91d2333`](https://github.com/immich-app/immich/commit/91d2333da2194e6063858e7521340a5d6b5a21f6) feat: more escape scenarios - [`a62df3f`](https://github.com/immich-app/immich/commit/a62df3f5227e7a326c518955035e4e20635c5cc1) feat: more escape shortcuts ### 📊 Changes **21 files changed** (+140 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/album-page/edit-description-modal.svelte` (+6 -7) 📝 `web/src/lib/components/asset-viewer/asset-viewer.svelte` (+4 -0) 📝 `web/src/lib/components/elements/dropdown.svelte` (+1 -1) 📝 `web/src/lib/components/map-page/map-settings-modal.svelte` (+4 -2) 📝 `web/src/lib/components/photos-page/actions/create-shared-link.svelte` (+11 -1) 📝 `web/src/lib/components/photos-page/actions/delete-assets.svelte` (+9 -0) 📝 `web/src/lib/components/photos-page/asset-grid.svelte` (+2 -2) 📝 `web/src/lib/components/shared-components/base-modal.svelte` (+1 -0) 📝 `web/src/lib/components/shared-components/confirm-dialogue.svelte` (+6 -1) 📝 `web/src/lib/components/shared-components/context-menu/context-menu.svelte` (+1 -0) 📝 `web/src/lib/components/shared-components/create-share-link-modal/create-shared-link-modal.svelte` (+1 -1) 📝 `web/src/lib/components/shared-components/full-screen-modal.svelte` (+10 -2) 📝 `web/src/lib/components/shared-components/navigation-bar/navigation-bar.svelte` (+5 -1) 📝 `web/src/lib/components/shared-components/search-bar/search-bar.svelte` (+2 -1) 📝 `web/src/lib/components/shared-components/show-shortcuts.svelte` (+1 -1) 📝 `web/src/lib/utils/click-outside.ts` (+2 -1) 📝 `web/src/routes/(user)/albums/+page.svelte` (+1 -1) 📝 `web/src/routes/(user)/albums/[albumId]/+page.svelte` (+28 -1) 📝 `web/src/routes/(user)/people/[personId]/+page.svelte` (+18 -1) 📝 `web/src/routes/(user)/photos/+page.svelte` (+23 -3) _...and 1 more files_ </details> ### 📄 Description This PR aims to enhance how the 'Escape' key shortcut is handled on the web app. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:16:02 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10102
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?