immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3702] [MERGED] fix(server): link live photos after metadata extraction finishes #10086

New Issue
Closed
opened 2026-02-05 14:15:46 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:46 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3702
Author: @jrasm91
Created: 8/15/2023
Status: ✅ Merged
Merged: 8/16/2023
Merged by: @alextran1502

Base: main ← Head: fix/3228

📝 Commits (3)

  • 8c01946 fix(server): link live photos after metadata extraction finishes
  • 31f9e85 chore: fix test
  • cee2081 Merge branch 'main' into fix/3228

📊 Changes

9 files changed (+64 additions, -30 deletions)

View changed files

📝 server/src/domain/album/album.repository.ts (+2 -0)
📝 server/src/domain/job/job.constants.ts (+2 -0)
📝 server/src/domain/job/job.repository.ts (+1 -0)
📝 server/src/domain/job/job.service.spec.ts (+4 -0)
📝 server/src/domain/job/job.service.ts (+5 -1)
📝 server/src/infra/repositories/album.repository.ts (+14 -3)
📝 server/src/microservices/app.service.ts (+1 -0)
📝 server/src/microservices/processors/metadata-extraction.processor.ts (+34 -26)
📝 server/test/repositories/album.repository.mock.ts (+1 -0)

📄 Description

Fixes #3228
Fixes #3430

In this PR:

  • Link live photos in a separate job after metadata extraction has completed (avoid runtime issue)
  • Remove motion part from any albums it was added to before being linked

Tested Scenarios:

  • Drag and drop still/motion to album (at the same time)
  • Upload from computer still/motion to album (at the same time)
  • Drag and drop still/motion to timeline (at the same time)
  • Upload video to album, observe video, upload still to album, observe live photo
  • Upload still to album, observe still, upload video to album, observe live photo

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3702 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 8/15/2023 **Status:** ✅ Merged **Merged:** 8/16/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/3228` --- ### 📝 Commits (3) - [`8c01946`](https://github.com/immich-app/immich/commit/8c01946e4afd10b2e7578beb8315341c923b6b72) fix(server): link live photos after metadata extraction finishes - [`31f9e85`](https://github.com/immich-app/immich/commit/31f9e85759574128c5ca81e1cfe49c545dcdd8b4) chore: fix test - [`cee2081`](https://github.com/immich-app/immich/commit/cee20813d138988083a46b18537756cdbd640729) Merge branch 'main' into fix/3228 ### 📊 Changes **9 files changed** (+64 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/album/album.repository.ts` (+2 -0) 📝 `server/src/domain/job/job.constants.ts` (+2 -0) 📝 `server/src/domain/job/job.repository.ts` (+1 -0) 📝 `server/src/domain/job/job.service.spec.ts` (+4 -0) 📝 `server/src/domain/job/job.service.ts` (+5 -1) 📝 `server/src/infra/repositories/album.repository.ts` (+14 -3) 📝 `server/src/microservices/app.service.ts` (+1 -0) 📝 `server/src/microservices/processors/metadata-extraction.processor.ts` (+34 -26) 📝 `server/test/repositories/album.repository.mock.ts` (+1 -0) </details> ### 📄 Description Fixes #3228 Fixes #3430 In this PR: - Link live photos in a separate job after metadata extraction has completed (avoid runtime issue) - Remove motion part from any albums it was added to before being linked Tested Scenarios: - Drag and drop still/motion to album (at the same time) - Upload from computer still/motion to album (at the same time) - Drag and drop still/motion to timeline (at the same time) - Upload video to album, observe video, upload still to album, observe live photo - Upload still to album, observe still, upload video to album, observe live photo --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:46 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10086
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?