immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3694] [MERGED] fix(web,server): use POST request to get download info #10080

New Issue
Closed
opened 2026-02-05 14:15:42 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:42 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3694
Author: @jrasm91
Created: 8/15/2023
Status: ✅ Merged
Merged: 8/15/2023
Merged by: @alextran1502

Base: main ← Head: fix/3679

📝 Commits (2)

  • 5bac672 fix(web,server): use POST request to get download info
  • cc1df2f chore: open api

📊 Changes

17 files changed (+398 additions, -231 deletions)

View changed files

📝 cli/src/api/open-api/api.ts (+50 -57)
📝 mobile/openapi/.openapi-generator/FILES (+3 -0)
📝 mobile/openapi/README.md (+3 -2)
📝 mobile/openapi/doc/AssetApi.md (+7 -13)
➕ mobile/openapi/doc/DownloadInfoDto.md (+18 -0)
📝 mobile/openapi/lib/api.dart (+1 -0)
📝 mobile/openapi/lib/api/asset_api.dart (+12 -36)
📝 mobile/openapi/lib/api_client.dart (+2 -0)
➕ mobile/openapi/lib/model/download_info_dto.dart (+150 -0)
📝 mobile/openapi/test/asset_api_test.dart (+1 -1)
➕ mobile/openapi/test/download_info_dto_test.dart (+42 -0)
📝 server/immich-openapi-specs.json (+47 -50)
📝 server/src/domain/asset/asset.service.ts (+3 -3)
📝 server/src/domain/asset/dto/download.dto.ts (+2 -1)
📝 server/src/immich/controllers/asset.controller.ts (+4 -4)
📝 web/src/api/open-api/api.ts (+50 -57)
📝 web/src/lib/utils/asset-utils.ts (+3 -7)

📄 Description

Fixes #3679

In this PR:

  • Use post request to get download info
    • POST /asset/download/info - get download info
    • POST /asset/download/archive- download archive

Tested scenarios:

  • Download large archive (results in 414 prior to change)
  • Download large archive (results in successful download with the new code)
  • Download single image from timeline
  • Download single image from viewer
  • Download multiple images from timeline
  • Download live photo from viewer
  • Download live photo from timeline

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3694 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 8/15/2023 **Status:** ✅ Merged **Merged:** 8/15/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `fix/3679` --- ### 📝 Commits (2) - [`5bac672`](https://github.com/immich-app/immich/commit/5bac67200894e2ed22e5e9ce261a7de226dca932) fix(web,server): use POST request to get download info - [`cc1df2f`](https://github.com/immich-app/immich/commit/cc1df2fddf7b1aaba682b0dd17ac87de3cf73870) chore: open api ### 📊 Changes **17 files changed** (+398 additions, -231 deletions) <details> <summary>View changed files</summary> 📝 `cli/src/api/open-api/api.ts` (+50 -57) 📝 `mobile/openapi/.openapi-generator/FILES` (+3 -0) 📝 `mobile/openapi/README.md` (+3 -2) 📝 `mobile/openapi/doc/AssetApi.md` (+7 -13) ➕ `mobile/openapi/doc/DownloadInfoDto.md` (+18 -0) 📝 `mobile/openapi/lib/api.dart` (+1 -0) 📝 `mobile/openapi/lib/api/asset_api.dart` (+12 -36) 📝 `mobile/openapi/lib/api_client.dart` (+2 -0) ➕ `mobile/openapi/lib/model/download_info_dto.dart` (+150 -0) 📝 `mobile/openapi/test/asset_api_test.dart` (+1 -1) ➕ `mobile/openapi/test/download_info_dto_test.dart` (+42 -0) 📝 `server/immich-openapi-specs.json` (+47 -50) 📝 `server/src/domain/asset/asset.service.ts` (+3 -3) 📝 `server/src/domain/asset/dto/download.dto.ts` (+2 -1) 📝 `server/src/immich/controllers/asset.controller.ts` (+4 -4) 📝 `web/src/api/open-api/api.ts` (+50 -57) 📝 `web/src/lib/utils/asset-utils.ts` (+3 -7) </details> ### 📄 Description Fixes #3679 In this PR: - Use post request to get download info - `POST /asset/download/info` - get download info - `POST /asset/download/archive`- download archive Tested scenarios: - Download large archive (results in 414 prior to change) - Download large archive (results in successful download with the new code) - Download single image from timeline - Download single image from viewer - Download multiple images from timeline - Download live photo from viewer - Download live photo from timeline --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:42 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10080
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?