immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-03-01 11:20:12 +03:00
Code Issues 783 Packages Projects Releases 12 Wiki Activity

[PR #3677] [CLOSED] refactor(web): system-settings #10071

New Issue
Closed
opened 2026-02-05 14:15:34 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:34 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3677
Author: @martabal
Created: 8/14/2023
Status: ❌ Closed

Base: main ← Head: refactor/system-settings

📝 Commits (10+)

📊 Changes

9 files changed (+866 additions, -1000 deletions)

View changed files

📝 web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte (+201 -247)
📝 web/src/lib/components/admin-page/settings/job-settings/job-settings.svelte (+32 -65)
📝 web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte (+147 -171)
📝 web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte (+128 -152)
📝 web/src/lib/components/admin-page/settings/password-login/password-login-settings.svelte (+44 -67)
📝 web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte (+81 -143)
📝 web/src/lib/components/admin-page/settings/thumbnail/thumbnail-settings.svelte (+56 -94)
📝 web/src/routes/admin/system-settings/+page.server.ts (+7 -1)
📝 web/src/routes/admin/system-settings/+page.svelte (+170 -60)

📄 Description

Changes made in this PR

  • reduce the number of API requests
  • improve the animations when toggling settings
  • currently, clicking on the Reset to default button disappear only after clicking on Save. It now disappears right after clicking on it

Screenshots

Before After

Edit: moved the data fetching on the page load from the client side to the server side so no more loading spinner !

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3677 **Author:** [@martabal](https://github.com/martabal) **Created:** 8/14/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `refactor/system-settings` --- ### 📝 Commits (10+) - [`0e4b00d`](https://github.com/immich-app/immich/commit/0e4b00d07a8bfd681fff1ecc0a7d23ea4d4ad0c6) refactor(web): system-settings - [`4b1e1f6`](https://github.com/immich-app/immich/commit/4b1e1f6e833cce68f89f6e3e11c3f66a617feb1a) feat: move the logic to the server - [`3674e5b`](https://github.com/immich-app/immich/commit/3674e5b85849c64ae8f0077b42bb2199c0fa53ce) pr feedback - [`6e2ba7a`](https://github.com/immich-app/immich/commit/6e2ba7acabba00d1c5b91776fe7f3c2b123d1718) merge main - [`4e98b10`](https://github.com/immich-app/immich/commit/4e98b1001be66ba9f10d8c6544b08ec26d00bcf5) fix: missing changes for job - [`77fb3e9`](https://github.com/immich-app/immich/commit/77fb3e9ce28d1718a6ed8101333a204f0572acbf) pr feedback - [`8b7a4f2`](https://github.com/immich-app/immich/commit/8b7a4f2169149c6aac71a702912d35ebb053dcc2) merge main - [`7226d12`](https://github.com/immich-app/immich/commit/7226d12d5dc1c51484d1f546bd01210593bfe0f2) merge main - [`1d544c8`](https://github.com/immich-app/immich/commit/1d544c8c4dfa31bc7868b34f44ee83a57c194000) fix: merge - [`4067541`](https://github.com/immich-app/immich/commit/406754195b8972a2e4c2b7650e61cbd8efc1550e) update machine learning ### 📊 Changes **9 files changed** (+866 additions, -1000 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte` (+201 -247) 📝 `web/src/lib/components/admin-page/settings/job-settings/job-settings.svelte` (+32 -65) 📝 `web/src/lib/components/admin-page/settings/machine-learning-settings/machine-learning-settings.svelte` (+147 -171) 📝 `web/src/lib/components/admin-page/settings/oauth/oauth-settings.svelte` (+128 -152) 📝 `web/src/lib/components/admin-page/settings/password-login/password-login-settings.svelte` (+44 -67) 📝 `web/src/lib/components/admin-page/settings/storage-template/storage-template-settings.svelte` (+81 -143) 📝 `web/src/lib/components/admin-page/settings/thumbnail/thumbnail-settings.svelte` (+56 -94) 📝 `web/src/routes/admin/system-settings/+page.server.ts` (+7 -1) 📝 `web/src/routes/admin/system-settings/+page.svelte` (+170 -60) </details> ### 📄 Description ## Changes made in this PR - reduce the number of API requests - improve the animations when toggling settings - currently, clicking on the `Reset to default` button disappear only after clicking on `Save`. It now disappears right after clicking on it ## Screenshots | Before | After | | --- | --- | | <video src="https://github.com/immich-app/immich/assets/74269598/d71aa86b-d68a-4d2b-ba74-5ddcc99b01b8"> | <video src="https://github.com/immich-app/immich/assets/74269598/c4828423-d728-423e-9e9b-b29f32dc1725">| Edit: moved the data fetching on the page load from the client side to the server side so no more loading spinner ! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:34 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?