immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3634] [MERGED] fix(web): show warning if upload completed with errors #2531 #10049

New Issue
Closed
opened 2026-02-05 14:15:12 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:12 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3634
Author: @sellnat77
Created: 8/10/2023
Status: ✅ Merged
Merged: 8/10/2023
Merged by: @alextran1502

Base: main ← Head: 2531-warnError

📝 Commits (1)

  • 6d386ed fix(web): show warning if upload completed with errors

📊 Changes

3 files changed (+18 additions, -2 deletions)

View changed files

📝 web/src/lib/components/shared-components/upload-panel.svelte (+14 -2)
📝 web/src/lib/stores/upload.ts (+2 -0)
📝 web/src/lib/utils/file-uploader.ts (+2 -0)

📄 Description

Description

  • Increments an errorCounter for all errors during upload
  • Uses the new warning notification if upload encountered errors during upload

Fixes #2531

How Has This Been Tested?

  • Upload picture -> simulate error -> verify warning notification with correct error count and only reports error instead of errors
  • Upload many pictures -> simulate multiple errors -> verify warning notification with correct count and reports errors instead of error
  • Upload many pictures without simulated errors -> verify standard success info notification pops up

Screenshots (if appropriate):

Screenshot from 2023-08-09 20-43-45
Screenshot from 2023-08-09 20-49-15
Screenshot from 2023-08-09 20-52-16

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3634 **Author:** [@sellnat77](https://github.com/sellnat77) **Created:** 8/10/2023 **Status:** ✅ Merged **Merged:** 8/10/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `2531-warnError` --- ### 📝 Commits (1) - [`6d386ed`](https://github.com/immich-app/immich/commit/6d386ed7c272ab4c787e98560061459430dd81bb) fix(web): show warning if upload completed with errors ### 📊 Changes **3 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/shared-components/upload-panel.svelte` (+14 -2) 📝 `web/src/lib/stores/upload.ts` (+2 -0) 📝 `web/src/lib/utils/file-uploader.ts` (+2 -0) </details> ### 📄 Description ## Description - Increments an `errorCounter` for all errors during upload - Uses the new warning notification if upload encountered errors during upload Fixes #2531 ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Upload picture -> simulate error -> verify warning notification with correct error count and only reports `error` instead of `errors` - [x] Upload many pictures -> simulate multiple errors -> verify warning notification with correct count and reports `errors` instead of `error` - [x] Upload many pictures without simulated errors -> verify standard success info notification pops up ## Screenshots (if appropriate): ![Screenshot from 2023-08-09 20-43-45](https://github.com/immich-app/immich/assets/3691245/bbdac983-39a9-4dfc-8a0f-452b248cb91b) ![Screenshot from 2023-08-09 20-49-15](https://github.com/immich-app/immich/assets/3691245/ebe73ebf-093a-4fd0-b1ae-e72f8cfabd38) ![Screenshot from 2023-08-09 20-52-16](https://github.com/immich-app/immich/assets/3691245/53f55666-4925-4537-b117-953c256cff29) ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:12 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?