immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3613] [MERGED] fix(web): show warning on duplicate uploads #2557 #10046

New Issue
Closed
opened 2026-02-05 14:15:08 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:08 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3613
Author: @sellnat77
Created: 8/9/2023
Status: ✅ Merged
Merged: 8/10/2023
Merged by: @alextran1502

Base: main ← Head: 2557-webDuplicates

📝 Commits (3)

📊 Changes

5 files changed (+33 additions, -1 deletions)

View changed files

📝 web/src/lib/components/shared-components/notification/notification-card.svelte (+13 -0)
📝 web/src/lib/components/shared-components/notification/notification.ts (+2 -1)
📝 web/src/lib/components/shared-components/upload-panel.svelte (+12 -0)
📝 web/src/lib/stores/upload.ts (+2 -0)
📝 web/src/lib/utils/file-uploader.ts (+4 -0)

📄 Description

Description

  • Adds a warning notification
  • Increments a duplicateCounter for all duplicates uploaded
  • Displays new duplicate warning notification of total duplicate count after upload

Fixes #2557

How Has This Been Tested?

  • Upload picture -> upload picture again -> verify warning notification with correct count and only reports picture instead of pictures
  • Upload many picture -> upload same pictures again -> verify warning notification with correct count and reports pictures instead of picture

Screenshots (if appropriate):

1_Duplicate
2_Duplicates

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

Credit:

Mostly copied from this PR but wanted to see the feature made, thank you @KotaUeshima!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3613 **Author:** [@sellnat77](https://github.com/sellnat77) **Created:** 8/9/2023 **Status:** ✅ Merged **Merged:** 8/10/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `2557-webDuplicates` --- ### 📝 Commits (3) - [`3c3c409`](https://github.com/immich-app/immich/commit/3c3c4093075358788ca1ec4b5a1a837a27e7b5a4) fix(web): show warning on duplicate uploads #2557 - [`6fc2f73`](https://github.com/immich-app/immich/commit/6fc2f7314151641b3fcd84f799205e2175bc0e0e) Prettier fix - [`f876fb6`](https://github.com/immich-app/immich/commit/f876fb6f8205cd5d376ac953a9c8c40512f4f830) color ### 📊 Changes **5 files changed** (+33 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/src/lib/components/shared-components/notification/notification-card.svelte` (+13 -0) 📝 `web/src/lib/components/shared-components/notification/notification.ts` (+2 -1) 📝 `web/src/lib/components/shared-components/upload-panel.svelte` (+12 -0) 📝 `web/src/lib/stores/upload.ts` (+2 -0) 📝 `web/src/lib/utils/file-uploader.ts` (+4 -0) </details> ### 📄 Description ## Description - Adds a warning notification - Increments a `duplicateCounter` for all duplicates uploaded - Displays new duplicate warning notification of total duplicate count after upload Fixes #2557 ## How Has This Been Tested? <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - [x] Upload picture -> upload picture again -> verify warning notification with correct count and only reports `picture` instead of `pictures` - [x] Upload many picture -> upload same pictures again -> verify warning notification with correct count and reports `pictures` instead of `picture` ## Screenshots (if appropriate): ![1_Duplicate](https://github.com/immich-app/immich/assets/3691245/99544e3c-c340-420f-b90e-9c417bf88f50) ![2_Duplicates](https://github.com/immich-app/immich/assets/3691245/286038c2-d607-4360-844c-0034e773816e) ## Checklist: - [x] I have performed a self-review of my own code - [x] I have made corresponding changes to the documentation if applicable ## Credit: Mostly copied from this [PR](https://github.com/immich-app/immich/pull/2845) but wanted to see the feature made, thank you @KotaUeshima! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:08 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10046
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?