immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-25 14:00:45 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3604] [MERGED] feat(web): timeline bucket for albums (4) #10043

New Issue
Closed
opened 2026-02-05 14:15:03 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:15:03 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3604
Author: @jrasm91
Created: 8/8/2023
Status: ✅ Merged
Merged: 8/11/2023
Merged by: @alextran1502

Base: main ← Head: feat/album-timeline

📝 Commits (5)

  • 889873b feat: server changes for album timeline
  • 73d6cad feat(web): album timeline view
  • 4199317 chore: open api
  • 2a45e67 chore: remove archive action
  • 1227530 fix: favorite for non-owners

📊 Changes

47 files changed (+1014 additions, -757 deletions)

View changed files

📝 cli/src/api/open-api/api.ts (+36 -5)
📝 mobile/openapi/doc/AlbumApi.md (+4 -2)
📝 mobile/openapi/doc/AlbumResponseDto.md (+3 -0)
📝 mobile/openapi/lib/api/album_api.dart (+10 -3)
📝 mobile/openapi/lib/model/album_response_dto.dart (+43 -1)
📝 mobile/openapi/test/album_api_test.dart (+1 -1)
📝 mobile/openapi/test/album_response_dto_test.dart (+15 -0)
📝 server/immich-openapi-specs.json (+20 -0)
📝 server/src/domain/album/album-response.dto.ts (+16 -5)
📝 server/src/domain/album/album.service.spec.ts (+7 -4)
📝 server/src/domain/album/album.service.ts (+18 -14)
➕ server/src/domain/album/dto/album.dto.ts (+10 -0)
📝 server/src/domain/album/dto/index.ts (+1 -0)
📝 server/src/domain/asset/asset.repository.ts (+3 -2)
📝 server/src/domain/asset/asset.service.ts (+14 -8)
📝 server/src/domain/search/search.service.ts (+2 -2)
📝 server/src/domain/shared-link/shared-link-response.dto.ts (+3 -3)
📝 server/src/immich/controllers/album.controller.ts (+10 -4)
📝 server/src/infra/repositories/album.repository.ts (+1 -0)
📝 server/src/infra/repositories/asset.repository.ts (+11 -8)

...and 27 more files

📄 Description

Fixes #3606, #3607

Related to:

In this PR:

  • Use time buckets on the album (not shared links though)
  • Add link icon under album title
  • Add owner icon to list of shared user icons
  • Add owner item to list of users (share info modal)
  • Add option to get album by id without return assets
  • Include new property (hasSharedLink) to know if there is at least one shared link on the album
  • Add typing to several dispatcher events
  • Simplify CreateSharedLinkModal interface
  • Add another UserAvatar size in between the previous md and lg.

Tested Scenarios:

  • Create a new album from select in the timeline (no share button)
  • Create a new album from asset view in the timeline
  • Create a new shared album from sharing page (shows share button)
  • Update album cover (thumbnail)
  • Add user to album
  • Remove user from album
  • Remove self from album (leave album)
  • Remove asset
  • Remove assets via shift+select
  • Remove assets via group select
  • Add assets via shift-select
  • Add assets via group select
  • Add/remove assets and album details (date, count) are correctly updated
  • Create album shared link
  • View link icon in share row (if owner)
  • No view link in share row (for non-owner)
  • Asset view next/previous work as expected
  • Delete from album shows up if all selected assets are owned by me (non owner)
  • Delete from album is not visible if selection includes a non-owned asset
  • Add asset from computer (owned)
  • Add asset from computer (non owned) immediately adds a broken thumbnail, which requires a refresh

Notes:

  • Creating a new album from a selection of assets in the album view doesn't reload the AssetGrid / page correctly.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3604 **Author:** [@jrasm91](https://github.com/jrasm91) **Created:** 8/8/2023 **Status:** ✅ Merged **Merged:** 8/11/2023 **Merged by:** [@alextran1502](https://github.com/alextran1502) **Base:** `main` ← **Head:** `feat/album-timeline` --- ### 📝 Commits (5) - [`889873b`](https://github.com/immich-app/immich/commit/889873b836e34ab2170ed27d550dfefa58452563) feat: server changes for album timeline - [`73d6cad`](https://github.com/immich-app/immich/commit/73d6cad6d04ad761282c905dda4d0bdd4f683a93) feat(web): album timeline view - [`4199317`](https://github.com/immich-app/immich/commit/4199317307e6ed97cb81f271bde4bcf73f2de9b6) chore: open api - [`2a45e67`](https://github.com/immich-app/immich/commit/2a45e677dcc7eaa68c008f430780647f8c0d8e77) chore: remove archive action - [`1227530`](https://github.com/immich-app/immich/commit/122753046501c086e25de5bf6b9bc05a76908419) fix: favorite for non-owners ### 📊 Changes **47 files changed** (+1014 additions, -757 deletions) <details> <summary>View changed files</summary> 📝 `cli/src/api/open-api/api.ts` (+36 -5) 📝 `mobile/openapi/doc/AlbumApi.md` (+4 -2) 📝 `mobile/openapi/doc/AlbumResponseDto.md` (+3 -0) 📝 `mobile/openapi/lib/api/album_api.dart` (+10 -3) 📝 `mobile/openapi/lib/model/album_response_dto.dart` (+43 -1) 📝 `mobile/openapi/test/album_api_test.dart` (+1 -1) 📝 `mobile/openapi/test/album_response_dto_test.dart` (+15 -0) 📝 `server/immich-openapi-specs.json` (+20 -0) 📝 `server/src/domain/album/album-response.dto.ts` (+16 -5) 📝 `server/src/domain/album/album.service.spec.ts` (+7 -4) 📝 `server/src/domain/album/album.service.ts` (+18 -14) ➕ `server/src/domain/album/dto/album.dto.ts` (+10 -0) 📝 `server/src/domain/album/dto/index.ts` (+1 -0) 📝 `server/src/domain/asset/asset.repository.ts` (+3 -2) 📝 `server/src/domain/asset/asset.service.ts` (+14 -8) 📝 `server/src/domain/search/search.service.ts` (+2 -2) 📝 `server/src/domain/shared-link/shared-link-response.dto.ts` (+3 -3) 📝 `server/src/immich/controllers/album.controller.ts` (+10 -4) 📝 `server/src/infra/repositories/album.repository.ts` (+1 -0) 📝 `server/src/infra/repositories/asset.repository.ts` (+11 -8) _...and 27 more files_ </details> ### 📄 Description Fixes #3606, #3607 Related to: - #3550 - #2370 - #2337 In this PR: - Use time buckets on the album (not shared links though) - Add link icon under album title - Add owner icon to list of shared user icons - Add owner item to list of users (share info modal) - Add option to get album by id without return assets - Include new property (`hasSharedLink`) to know if there is at least one shared link on the album - Add typing to several dispatcher events - Simplify `CreateSharedLinkModal` interface - Add another `UserAvatar` size in between the previous `md` and `lg`. Tested Scenarios: - Create a new album from select in the timeline (no share button) - Create a new album from asset view in the timeline - Create a new shared album from sharing page (shows share button) - Update album cover (thumbnail) - Add user to album - Remove user from album - Remove self from album (leave album) - Remove asset - Remove assets via shift+select - Remove assets via group select - Add assets via shift-select - Add assets via group select - Add/remove assets and album details (date, count) are correctly updated - Create album shared link - View link icon in share row (if owner) - No view link in share row (for non-owner) - Asset view next/previous work as expected - Delete from album shows up if all selected assets are owned by me (non owner) - Delete from album is not visible if selection includes a non-owned asset - Add asset from computer (owned) - Add asset from computer (non owned) immediately adds a broken thumbnail, which requires a refresh Notes: - Creating a _new_ album from a selection of assets in the album view doesn't reload the `AssetGrid` / page correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:15:03 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10043
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?