immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2026-07-16 05:34:30 +03:00
Code Issues 783 Packages Projects Releases 22 Wiki Activity

[PR #3577] [CLOSED] fix(server): convert to nv12 before using nvenc #10035

New Issue
Closed
opened 2026-02-05 14:14:56 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-05 14:14:56 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/immich-app/immich/pull/3577
Author: @mertalev
Created: 8/7/2023
Status: ❌ Closed

Base: main ← Head: fix/server-nvenc-nv12

📝 Commits (1)

  • 10b1b42 convert to nv12 before nvenc

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 server/src/domain/media/media.service.spec.ts (+5 -5)
📝 server/src/domain/media/media.util.ts (+1 -1)

📄 Description

Description

This is a small fix for NVENC accel. It's missing format=nv12, so HDR content will fail and fallback to software transcoding. With this change, they'll be converted to the format expected by GPUs.

How Has This Been Tested?

I encountered this bug while testing the tone-mapping PR. With this change applied, the HDR video I used for testing transcoded without error.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/immich-app/immich/pull/3577 **Author:** [@mertalev](https://github.com/mertalev) **Created:** 8/7/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/server-nvenc-nv12` --- ### 📝 Commits (1) - [`10b1b42`](https://github.com/immich-app/immich/commit/10b1b422ad126e059b918c702caa6844bbb5a9be) convert to nv12 before nvenc ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `server/src/domain/media/media.service.spec.ts` (+5 -5) 📝 `server/src/domain/media/media.util.ts` (+1 -1) </details> ### 📄 Description ## Description This is a small fix for NVENC accel. It's missing `format=nv12`, so HDR content will fail and fallback to software transcoding. With this change, they'll be converted to the format expected by GPUs. ## How Has This Been Tested? I encountered this bug while testing the tone-mapping PR. With this change applied, the HDR video I used for testing transcoded without error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-05 14:14:56 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
accessibility
changelog:enhancement
changelog:security
changelog:skip
changelog:translation
cli
date-time
dependencies
documentation
external-library
format
good first issue
mobile-beta
mobile-beta
mobile-beta
needs-answer
nice to have
pull-request
Mirrored from GitHub Pull Request
 sharing
tech-debt
📱mobile
🖥️web
🗄️server
🧠machine-learning
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: immich-app/immich#10035
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?