Merge branch 'main' of github.com:immich-app/immich into better-info-in-asset-viewer

i18n/en.json

@@ -10,7 +10,6 @@
   "active_count": "Active: {count}",
   "activity": "Activity",
   "activity_changed": "Activity is {enabled, select, true {enabled} other {disabled}}",
-  "activity_count": "{count, plural, =0 {Activity} =1 {1 activity} other {{count} activities}}",
   "add": "Add",
   "add_a_description": "Add a description",
   "add_a_location": "Add a location",
@@ -1287,6 +1286,7 @@
   "link_to_oauth": "Link to OAuth",
   "linked_oauth_account": "Linked OAuth account",
   "list": "List",
+  "live": "Live",
   "loading": "Loading",
   "loading_search_results_failed": "Loading search results failed",
   "local": "Local",
@@ -1416,6 +1416,7 @@
   "month": "Month",
   "monthly_title_text_date_format": "MMMM y",
   "more": "More",
+  "motion": "Motion",
   "move": "Move",
   "move_off_locked_folder": "Move out of locked folder",
   "move_to": "Move to",

i18n/ja.json

@@ -9,7 +9,6 @@
   "active": "アクティブ",
   "activity": "アクティビティ",
   "activity_changed": "アクティビティは{enabled, select, true {有効} other {無効}}になりました",
-  "activity_count": "{count, plural, =0 {コメント} other {コメント\n{count}件}}",
   "add": "追加",
   "add_a_description": "説明を追加",
   "add_a_location": "場所を追加",

mobile/lib/constants/enums.dart

@@ -7,5 +7,3 @@ enum AssetVisibilityEnum { timeline, hidden, archive, locked }
 enum SortUserBy { id }
 
 enum ActionSource { timeline, viewer }
-
-enum ButtonPosition { bottomBar, kebabMenu, other }

mobile/lib/models/activities/activity.model.dart

@@ -62,9 +62,6 @@ class Activity {
 
 class ActivityStats {
   final int comments;
-  final int likes;
 
-  const ActivityStats({required this.comments, required this.likes});
+  const ActivityStats({required this.comments});
-
-  int get total => comments + likes;
 }

mobile/lib/presentation/widgets/action_buttons/edit_image_action_button.widget.dart

@@ -8,10 +8,7 @@ import 'package:immich_mobile/providers/infrastructure/asset_viewer/current_asse
 import 'package:immich_mobile/routing/router.dart';
 
 class EditImageActionButton extends ConsumerWidget {
-  final bool iconOnly;
+  const EditImageActionButton({super.key});
-  final bool menuItem;
-
-  const EditImageActionButton({super.key, this.iconOnly = false, this.menuItem = false});
 
   @override
   Widget build(BuildContext context, WidgetRef ref) {
@@ -30,8 +27,6 @@ class EditImageActionButton extends ConsumerWidget {
       iconData: Icons.tune,
       label: "edit".t(context: context),
       onPressed: onPress,
-      iconOnly: iconOnly,
-      menuItem: menuItem,
     );
   }
 }

mobile/lib/presentation/widgets/action_buttons/open_activity_action_button.widget.dart

@@ -1,32 +0,0 @@
-import 'package:flutter/material.dart';
-import 'package:hooks_riverpod/hooks_riverpod.dart';
-import 'package:immich_mobile/domain/models/asset/base_asset.model.dart';
-import 'package:immich_mobile/domain/models/events.model.dart';
-import 'package:immich_mobile/domain/utils/event_stream.dart';
-import 'package:immich_mobile/extensions/translate_extensions.dart';
-import 'package:immich_mobile/presentation/widgets/action_buttons/base_action_button.widget.dart';
-import 'package:immich_mobile/providers/activity_statistics.provider.dart';
-import 'package:immich_mobile/providers/infrastructure/asset_viewer/current_asset.provider.dart';
-import 'package:immich_mobile/providers/infrastructure/current_album.provider.dart';
-
-class OpenActivityActionButton extends ConsumerWidget {
-  const OpenActivityActionButton({super.key, this.iconOnly = false, this.menuItem = false});
-
-  final bool iconOnly;
-  final bool menuItem;
-
-  @override
-  Widget build(BuildContext context, WidgetRef ref) {
-    final album = ref.watch(currentRemoteAlbumProvider);
-    final asset = ref.watch(currentAssetNotifier) as RemoteAsset?;
-    final count = album != null && album.id.isNotEmpty ? ref.watch(activityStatisticsProvider(album.id, asset?.id)) : 0;
-
-    return BaseActionButton(
-      iconData: Icons.chat_outlined,
-      label: "activity_count".t(args: {"count": count}),
-      onPressed: () => EventStream.shared.emit(const ViewerOpenBottomSheetEvent(activitiesMode: true)),
-      iconOnly: iconOnly,
-      menuItem: menuItem,
-    );
-  }
-}

mobile/lib/presentation/widgets/asset_viewer/asset_viewer.page.dart

@@ -20,6 +20,7 @@ import 'package:immich_mobile/presentation/widgets/asset_viewer/asset_stack.widg
 import 'package:immich_mobile/presentation/widgets/asset_viewer/asset_viewer.state.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/bottom_bar.widget.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/bottom_sheet.widget.dart';
+import 'package:immich_mobile/presentation/widgets/asset_viewer/motion_photo_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/top_app_bar.widget.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/video_viewer.widget.dart';
 import 'package:immich_mobile/presentation/widgets/images/image_provider.dart';
@@ -692,6 +693,7 @@ class _AssetViewerState extends ConsumerState<AssetViewer> {
               backgroundDecoration: BoxDecoration(color: backgroundColor),
               enablePanAlways: true,
             ),
+            const Positioned(top: -50, left: 0, right: 0, child: MotionPhotoPlayButton()),
             if (!showingBottomSheet)
               const Positioned(
                 bottom: 0,

mobile/lib/presentation/widgets/asset_viewer/bottom_bar.widget.dart

@@ -2,18 +2,18 @@ import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/constants/enums.dart';
 import 'package:immich_mobile/domain/models/asset/base_asset.model.dart';
-import 'package:immich_mobile/domain/models/setting.model.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/delete_action_button.widget.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/delete_local_action_button.widget.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/edit_image_action_button.widget.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/share_action_button.widget.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/upload_action_button.widget.dart';
+import 'package:immich_mobile/presentation/widgets/action_buttons/add_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/asset_viewer.state.dart';
 import 'package:immich_mobile/providers/infrastructure/asset_viewer/current_asset.provider.dart';
-import 'package:immich_mobile/providers/infrastructure/current_album.provider.dart';
 import 'package:immich_mobile/providers/infrastructure/readonly_mode.provider.dart';
-import 'package:immich_mobile/providers/infrastructure/setting.provider.dart';
-import 'package:immich_mobile/providers/infrastructure/timeline.provider.dart';
 import 'package:immich_mobile/providers/routes.provider.dart';
-import 'package:immich_mobile/providers/server_info.provider.dart';
 import 'package:immich_mobile/providers/user.provider.dart';
-import 'package:immich_mobile/utils/action_button.utils.dart';
 import 'package:immich_mobile/widgets/asset_viewer/video_controls.dart';
 
 class ViewerBottomBar extends ConsumerWidget {
@@ -33,11 +33,6 @@ class ViewerBottomBar extends ConsumerWidget {
     int opacity = ref.watch(assetViewerProvider.select((state) => state.backgroundOpacity));
     final showControls = ref.watch(assetViewerProvider.select((s) => s.showingControls));
     final isInLockedView = ref.watch(inLockedViewProvider);
-    final album = ref.watch(currentRemoteAlbumProvider);
-    final isArchived = asset is RemoteAsset && asset.visibility == AssetVisibility.archive;
-    final advancedTroubleshooting = ref.watch(settingsProvider.notifier).get(Setting.advancedTroubleshooting);
-    final timelineOrigin = ref.read(timelineServiceProvider).origin;
-    final isTrashEnable = ref.watch(serverInfoProvider.select((state) => state.serverFeatures.trash));
 
     if (!showControls) {
       opacity = 0;
@@ -45,22 +40,21 @@ class ViewerBottomBar extends ConsumerWidget {
 
     final originalTheme = context.themeData;
 
-    final buttonContext = ActionButtonContext(
+    final actions = <Widget>[
-      asset: asset,
+      const ShareActionButton(source: ActionSource.viewer),
-      isOwner: isOwner,
-      isArchived: isArchived,
-      isTrashEnabled: isTrashEnable,
-      isStacked: asset is RemoteAsset && asset.stackId != null,
-      isInLockedView: isInLockedView,
-      currentAlbum: album,
-      advancedTroubleshooting: advancedTroubleshooting,
-      source: ActionSource.viewer,
-      timelineOrigin: timelineOrigin,
-      originalTheme: originalTheme,
-      buttonPosition: ButtonPosition.bottomBar,
-    );
 
-    final actions = ActionButtonBuilder.buildViewerBottomBar(buttonContext, context, ref);
+      if (!isInLockedView) ...[
+        if (asset.isLocalOnly) const UploadActionButton(source: ActionSource.viewer),
+        if (asset.type == AssetType.image) const EditImageActionButton(),
+        if (asset.hasRemote) AddActionButton(originalTheme: originalTheme),
+
+        if (isOwner) ...[
+          asset.isLocalOnly
+              ? const DeleteLocalActionButton(source: ActionSource.viewer)
+              : const DeleteActionButton(source: ActionSource.viewer, showConfirmation: true),
+        ],
+      ],
+    ];
 
     return IgnorePointer(
       ignoring: opacity < 255,
@@ -86,11 +80,7 @@ class ViewerBottomBar extends ConsumerWidget {
                       children: [
                         if (asset.isVideo) const VideoControls(),
                         if (!isReadonlyModeEnabled)
-                          Row(
+                          Row(mainAxisAlignment: MainAxisAlignment.spaceEvenly, children: actions),
-                            mainAxisAlignment: MainAxisAlignment.spaceEvenly,
-                            crossAxisAlignment: CrossAxisAlignment.start,
-                            children: actions.map((action) => Expanded(child: action)).toList(),
-                          ),
                       ],
                     ),
                   ),

mobile/lib/presentation/widgets/asset_viewer/motion_photo_button.widget.dart

@@ -0,0 +1,79 @@
+import 'package:flutter/material.dart';
+import 'package:hooks_riverpod/hooks_riverpod.dart';
+import 'package:immich_mobile/extensions/platform_extensions.dart';
+import 'package:immich_mobile/extensions/translate_extensions.dart';
+import 'package:immich_mobile/presentation/widgets/asset_viewer/asset_viewer.state.dart';
+import 'package:immich_mobile/providers/asset_viewer/is_motion_video_playing.provider.dart';
+import 'package:immich_mobile/providers/infrastructure/asset_viewer/current_asset.provider.dart';
+
+class MotionPhotoPlayButton extends ConsumerWidget {
+  const MotionPhotoPlayButton({super.key});
+
+  @override
+  Widget build(BuildContext context, WidgetRef ref) {
+    final asset = ref.watch(currentAssetNotifier);
+    final isPlaying = ref.watch(isPlayingMotionVideoProvider);
+    final showControls = ref.watch(assetViewerProvider.select((state) => state.showingControls));
+    final isShowingSheet = ref.watch(assetViewerProvider.select((state) => state.showingBottomSheet));
+
+    if (asset == null || !asset.isMotionPhoto || isShowingSheet) {
+      return const SizedBox.shrink();
+    }
+
+    return IgnorePointer(
+      ignoring: !showControls,
+      child: AnimatedOpacity(
+        opacity: showControls ? 1.0 : 0.0,
+        duration: Durations.short2,
+        child: SafeArea(
+          child: Padding(
+            padding: const EdgeInsets.only(top: 60),
+            child: Center(
+              child: _MotionButton(
+                isPlaying: isPlaying,
+                onPressed: ref.read(isPlayingMotionVideoProvider.notifier).toggle,
+              ),
+            ),
+          ),
+        ),
+      ),
+    );
+  }
+}
+
+class _MotionButton extends StatelessWidget {
+  final bool isPlaying;
+  final VoidCallback onPressed;
+
+  const _MotionButton({required this.isPlaying, required this.onPressed});
+
+  @override
+  Widget build(BuildContext context) {
+    return Material(
+      color: Colors.grey[900]!.withValues(alpha: 0.4),
+      borderRadius: const BorderRadius.all(Radius.circular(24)),
+      child: InkWell(
+        onTap: onPressed,
+        borderRadius: const BorderRadius.all(Radius.circular(24)),
+        child: Padding(
+          padding: const EdgeInsets.symmetric(horizontal: 8, vertical: 6),
+          child: Row(
+            mainAxisSize: MainAxisSize.min,
+            children: [
+              Icon(
+                isPlaying ? Icons.motion_photos_pause_outlined : Icons.play_circle_outline_rounded,
+                color: Colors.white,
+                size: 16,
+              ),
+              const SizedBox(width: 8),
+              Text(
+                CurrentPlatform.isAndroid ? 'motion'.t(context: context) : 'live'.t(context: context),
+                style: const TextStyle(color: Colors.white, fontSize: 14, fontWeight: FontWeight.w500),
+              ),
+            ],
+          ),
+        ),
+      ),
+    );
+  }
+}

mobile/lib/presentation/widgets/asset_viewer/top_app_bar.widget.dart

@@ -1,11 +1,13 @@
 import 'package:auto_route/auto_route.dart';
+import 'package:easy_localization/easy_localization.dart';
 import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
 import 'package:immich_mobile/constants/enums.dart';
 import 'package:immich_mobile/domain/models/asset/base_asset.model.dart';
+import 'package:immich_mobile/domain/models/events.model.dart';
+import 'package:immich_mobile/domain/utils/event_stream.dart';
 import 'package:immich_mobile/extensions/build_context_extensions.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/favorite_action_button.widget.dart';
-import 'package:immich_mobile/presentation/widgets/action_buttons/motion_photo_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/unfavorite_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/asset_viewer.state.dart';
 import 'package:immich_mobile/presentation/widgets/asset_viewer/viewer_kebab_menu.widget.dart';
@@ -15,6 +17,7 @@ import 'package:immich_mobile/providers/infrastructure/current_album.provider.da
 import 'package:immich_mobile/providers/infrastructure/readonly_mode.provider.dart';
 import 'package:immich_mobile/providers/routes.provider.dart';
 import 'package:immich_mobile/providers/user.provider.dart';
+import 'package:immich_mobile/utils/timezone.dart';
 
 class ViewerTopAppBar extends ConsumerWidget implements PreferredSizeWidget {
   const ViewerTopAppBar({super.key});
@@ -48,7 +51,13 @@ class ViewerTopAppBar extends ConsumerWidget implements PreferredSizeWidget {
     final originalTheme = context.themeData;
 
     final actions = <Widget>[
-      if (asset.isMotionPhoto) const MotionPhotoActionButton(iconOnly: true),
+      if (album != null && album.isActivityEnabled && album.isShared)
+        IconButton(
+          icon: const Icon(Icons.chat_outlined),
+          onPressed: () {
+            EventStream.shared.emit(const ViewerOpenBottomSheetEvent(activitiesMode: true));
+          },
+        ),
 
       if (asset.hasRemote && isOwner && !asset.isFavorite)
         const FavoriteActionButton(source: ActionSource.viewer, iconOnly: true),
@@ -68,6 +77,8 @@ class ViewerTopAppBar extends ConsumerWidget implements PreferredSizeWidget {
         child: AppBar(
           backgroundColor: isShowingSheet ? Colors.transparent : Colors.black.withAlpha(125),
           leading: const _AppBarBackButton(),
+          centerTitle: true,
+          title: isShowingSheet ? null : _AssetInfoTitle(asset: asset),
           iconTheme: const IconThemeData(size: 22, color: Colors.white),
           actionsIconTheme: const IconThemeData(size: 22, color: Colors.white),
           shape: const Border(),
@@ -111,3 +122,32 @@ class _AppBarBackButton extends ConsumerWidget {
     );
   }
 }
+
+class _AssetInfoTitle extends ConsumerWidget {
+  final BaseAsset asset;
+
+  const _AssetInfoTitle({required this.asset});
+
+  @override
+  Widget build(BuildContext context, WidgetRef ref) {
+    DateTime dateTime = asset.createdAt.toLocal();
+    final currentYear = DateTime.now().year;
+    final isCurrentYear = dateTime.year == currentYear;
+    final exifInfo = ref.watch(currentAssetExifProvider).valueOrNull;
+
+    if (exifInfo?.dateTimeOriginal != null) {
+      (dateTime, _) = applyTimezoneOffset(dateTime: exifInfo!.dateTimeOriginal!, timeZone: exifInfo.timeZone);
+    }
+
+    final dateFormatted = isCurrentYear ? DateFormat.MMMd().format(dateTime) : DateFormat.yMMMd().format(dateTime);
+    final timeFormatted = DateFormat.jm().format(dateTime);
+
+    return Column(
+      mainAxisSize: MainAxisSize.min,
+      children: [
+        Text(dateFormatted, style: context.textTheme.labelLarge?.copyWith(color: Colors.white)),
+        Text(timeFormatted, style: context.textTheme.labelMedium?.copyWith(color: Colors.white70)),
+      ],
+    );
+  }
+}

mobile/lib/providers/activity.provider.dart

@@ -26,13 +26,14 @@ class AlbumActivity extends _$AlbumActivity {
         ref.read(albumActivityProvider(albumId).notifier)._removeFromState(id);
       }
 
-      // Update statistics for both comments and likes
+      if (removedActivity.type == ActivityType.comment) {
         ref.watch(activityStatisticsProvider(albumId, assetId).notifier).removeActivity();
         if (assetId != null) {
           ref.watch(activityStatisticsProvider(albumId).notifier).removeActivity();
         }
       }
     }
+  }
 
   Future<void> addLike() async {
     final activity = await ref.watch(activityServiceProvider).addActivity(albumId, ActivityType.like, assetId: assetId);
@@ -41,11 +42,6 @@ class AlbumActivity extends _$AlbumActivity {
       if (assetId != null) {
         ref.read(albumActivityProvider(albumId).notifier)._addToState(activity.requireValue);
       }
-      // Update statistics when adding a like
-      ref.watch(activityStatisticsProvider(albumId, assetId).notifier).addActivity();
-      if (assetId != null) {
-        ref.watch(activityStatisticsProvider(albumId).notifier).addActivity();
-      }
     }
   }
 

mobile/lib/providers/activity.provider.g.dart

@@ -6,7 +6,7 @@ part of 'activity.provider.dart';
 // RiverpodGenerator
 // **************************************************************************
 
-String _$albumActivityHash() => r'fe472b87b56ce4e3802833799bf707779ccc02e3';
+String _$albumActivityHash() => r'154e8ae98da3efc142369eae46d4005468fd67da';
 
 /// Copied from Dart SDK
 class _SystemHash {

mobile/lib/providers/activity_statistics.provider.dart

@@ -4,12 +4,12 @@ import 'package:riverpod_annotation/riverpod_annotation.dart';
 part 'activity_statistics.provider.g.dart';
 
 // ignore: unintended_html_in_doc_comment
-/// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+/// Maintains the current number of comments by <shared-album, asset>
 @riverpod
 class ActivityStatistics extends _$ActivityStatistics {
   @override
   int build(String albumId, [String? assetId]) {
-    ref.watch(activityServiceProvider).getStatistics(albumId, assetId: assetId).then((stats) => state = stats.total);
+    ref.watch(activityServiceProvider).getStatistics(albumId, assetId: assetId).then((stats) => state = stats.comments);
     return 0;
   }
 

mobile/lib/providers/activity_statistics.provider.g.dart

@@ -7,7 +7,7 @@ part of 'activity_statistics.provider.dart';
 // **************************************************************************
 
 String _$activityStatisticsHash() =>
-    r'ae0123a6ce129988e21f7327273af4d9acbae0f6';
+    r'1f43f0bcb11c754ca3cb586a13570db25023b9a8';
 
 /// Copied from Dart SDK
 class _SystemHash {
@@ -37,22 +37,22 @@ abstract class _$ActivityStatistics extends BuildlessAutoDisposeNotifier<int> {
   int build(String albumId, [String? assetId]);
 }
 
-/// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+/// Maintains the current number of comments by <shared-album, asset>
 ///
 /// Copied from [ActivityStatistics].
 @ProviderFor(ActivityStatistics)
 const activityStatisticsProvider = ActivityStatisticsFamily();
 
-/// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+/// Maintains the current number of comments by <shared-album, asset>
 ///
 /// Copied from [ActivityStatistics].
 class ActivityStatisticsFamily extends Family<int> {
-  /// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+  /// Maintains the current number of comments by <shared-album, asset>
   ///
   /// Copied from [ActivityStatistics].
   const ActivityStatisticsFamily();
 
-  /// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+  /// Maintains the current number of comments by <shared-album, asset>
   ///
   /// Copied from [ActivityStatistics].
   ActivityStatisticsProvider call(String albumId, [String? assetId]) {
@@ -81,12 +81,12 @@ class ActivityStatisticsFamily extends Family<int> {
   String? get name => r'activityStatisticsProvider';
 }
 
-/// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+/// Maintains the current number of comments by <shared-album, asset>
 ///
 /// Copied from [ActivityStatistics].
 class ActivityStatisticsProvider
     extends AutoDisposeNotifierProviderImpl<ActivityStatistics, int> {
-  /// Maintains the current number of activities (comments + likes) by <shared-album, asset>
+  /// Maintains the current number of comments by <shared-album, asset>
   ///
   /// Copied from [ActivityStatistics].
   ActivityStatisticsProvider(String albumId, [String? assetId])

mobile/lib/repositories/activity_api.repository.dart

@@ -36,7 +36,7 @@ class ActivityApiRepository extends ApiRepository {
 
   Future<ActivityStats> getStats(String albumId, {String? assetId}) async {
     final response = await checkNull(_api.getActivityStatistics(albumId, assetId: assetId));
-    return ActivityStats(comments: response.comments, likes: response.likes);
+    return ActivityStats(comments: response.comments);
   }
 
   static Activity _toActivity(ActivityResponseDto dto) => Activity(

mobile/lib/services/activity.service.dart

@@ -32,7 +32,7 @@ class ActivityService with ErrorLoggerMixin {
   Future<ActivityStats> getStatistics(String albumId, {String? assetId}) async {
     return logError(
       () => _activityApiRepository.getStats(albumId, assetId: assetId),
-      defaultValue: const ActivityStats(comments: 0, likes: 0),
+      defaultValue: const ActivityStats(comments: 0),
       errorMessage: "Failed to statistics for album $albumId",
     );
   }

mobile/lib/utils/action_button.utils.dart

@@ -17,7 +17,6 @@ import 'package:immich_mobile/presentation/widgets/action_buttons/delete_local_a
 import 'package:immich_mobile/presentation/widgets/action_buttons/delete_permanent_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/download_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/like_activity_action_button.widget.dart';
-import 'package:immich_mobile/presentation/widgets/action_buttons/open_activity_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/move_to_lock_folder_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/remove_from_album_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/remove_from_lock_folder_action_button.widget.dart';
@@ -28,8 +27,6 @@ import 'package:immich_mobile/presentation/widgets/action_buttons/trash_action_b
 import 'package:immich_mobile/presentation/widgets/action_buttons/unarchive_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/unstack_action_button.widget.dart';
 import 'package:immich_mobile/presentation/widgets/action_buttons/upload_action_button.widget.dart';
-import 'package:immich_mobile/presentation/widgets/action_buttons/edit_image_action_button.widget.dart';
-import 'package:immich_mobile/presentation/widgets/action_buttons/add_action_button.widget.dart';
 import 'package:immich_mobile/routing/router.dart';
 
 class ActionButtonContext {
@@ -45,7 +42,6 @@ class ActionButtonContext {
   final bool isCasting;
   final TimelineOrigin timelineOrigin;
   final ThemeData? originalTheme;
-  final ButtonPosition buttonPosition;
 
   const ActionButtonContext({
     required this.asset,
@@ -60,34 +56,13 @@ class ActionButtonContext {
     this.isCasting = false,
     this.timelineOrigin = TimelineOrigin.main,
     this.originalTheme,
-    this.buttonPosition = ButtonPosition.other,
   });
-
-  ActionButtonContext withButtonPosition(ButtonPosition position) {
-    return ActionButtonContext(
-      asset: asset,
-      isOwner: isOwner,
-      isArchived: isArchived,
-      isTrashEnabled: isTrashEnabled,
-      isStacked: isStacked,
-      isInLockedView: isInLockedView,
-      currentAlbum: currentAlbum,
-      advancedTroubleshooting: advancedTroubleshooting,
-      source: source,
-      isCasting: isCasting,
-      timelineOrigin: timelineOrigin,
-      originalTheme: originalTheme,
-      buttonPosition: position,
-    );
-  }
 }
 
 enum ActionButtonType {
   openInfo,
-  openActivity,
   likeActivity,
   share,
-  editImage,
   shareLink,
   cast,
   similarPhotos,
@@ -104,7 +79,6 @@ enum ActionButtonType {
   deleteLocal,
   deletePermanent,
   delete,
-  addTo,
   advancedInfo;
 
   bool shouldShow(ActionButtonContext context) {
@@ -182,22 +156,10 @@ enum ActionButtonType {
             context.timelineOrigin != TimelineOrigin.localAlbum &&
             context.isOwner,
       ActionButtonType.cast => context.isCasting || context.asset.hasRemote,
-      ActionButtonType.editImage =>
-        !context.isInLockedView && //
-            context.asset.type == AssetType.image &&
-            !(context.buttonPosition == ButtonPosition.bottomBar && context.currentAlbum?.isShared == true),
-      ActionButtonType.addTo =>
-        !context.isInLockedView && //
-            context.asset.hasRemote,
-      ActionButtonType.openActivity =>
-        !context.isInLockedView &&
-            context.currentAlbum != null &&
-            context.currentAlbum!.isActivityEnabled &&
-            context.currentAlbum!.isShared,
     };
   }
 
-  Widget buildButton(
+  ConsumerWidget buildButton(
     ActionButtonContext context, [
     BuildContext? buildContext,
     bool iconOnly = false,
@@ -280,9 +242,6 @@ enum ActionButtonType {
               },
       ),
       ActionButtonType.cast => CastActionButton(iconOnly: iconOnly, menuItem: menuItem),
-      ActionButtonType.editImage => EditImageActionButton(iconOnly: iconOnly, menuItem: menuItem),
-      ActionButtonType.addTo => AddActionButton(originalTheme: context.originalTheme),
-      ActionButtonType.openActivity => OpenActivityActionButton(iconOnly: iconOnly, menuItem: menuItem),
     };
   }
 
@@ -313,77 +272,39 @@ enum ActionButtonType {
 class ActionButtonBuilder {
   static const List<ActionButtonType> _actionTypes = ActionButtonType.values;
   static const List<ActionButtonType> defaultViewerKebabMenuOrder = _actionTypes;
-  static const List<ActionButtonType> _defaultViewerBottomBarOrder = [
+  static const Set<ActionButtonType> defaultViewerBottomBarButtons = {
     ActionButtonType.share,
+    ActionButtonType.moveToLockFolder,
     ActionButtonType.upload,
-    ActionButtonType.editImage,
-    ActionButtonType.addTo,
-    ActionButtonType.openActivity,
-    ActionButtonType.likeActivity,
-    ActionButtonType.deleteLocal,
     ActionButtonType.delete,
-    ActionButtonType.removeFromLockFolder,
+    ActionButtonType.archive,
-    ActionButtonType.deletePermanent,
+    ActionButtonType.unarchive,
-  ];
+  };
 
   static List<Widget> build(ActionButtonContext context) {
     return _actionTypes.where((type) => type.shouldShow(context)).map((type) => type.buildButton(context)).toList();
   }
 
-  static List<ActionButtonType> getViewerKebabMenuTypes(ActionButtonContext context) {
-    final visibleBottomBarButtons = getViewerBottomBarTypes(context);
-    final excludedTypes = <ActionButtonType>{...visibleBottomBarButtons, ActionButtonType.addTo};
-
-    if (visibleBottomBarButtons.contains(ActionButtonType.addTo)) {
-      excludedTypes.addAll([ActionButtonType.moveToLockFolder, ActionButtonType.archive, ActionButtonType.unarchive]);
-    }
-
-    return defaultViewerKebabMenuOrder
-        .where((type) => !excludedTypes.contains(type) && type.shouldShow(context))
-        .toList();
-  }
-
-  static List<ActionButtonType> getViewerBottomBarTypes(ActionButtonContext context) {
-    final bottomBarContext = context.withButtonPosition(ButtonPosition.bottomBar);
-    return _defaultViewerBottomBarOrder.where((type) => type.shouldShow(bottomBarContext)).take(4).toList();
-  }
-
   static List<Widget> buildViewerKebabMenu(ActionButtonContext context, BuildContext buildContext, WidgetRef ref) {
-    final visibleButtons = getViewerKebabMenuTypes(context);
+    final visibleButtons = defaultViewerKebabMenuOrder
-    return visibleButtons.toKebabMenuWidgets(context, buildContext, ref);
+        .where((type) => !defaultViewerBottomBarButtons.contains(type) && type.shouldShow(context))
-  }
+        .toList();
 
-  static List<Widget> buildViewerBottomBar(ActionButtonContext context, BuildContext buildContext, WidgetRef ref) {
+    if (visibleButtons.isEmpty) {
-    final visibleButtons = getViewerBottomBarTypes(context);
-    return visibleButtons.toBottomBarWidgets(context, buildContext, ref);
-  }
-}
-
-extension ActionButtonTypeListExtension on List<ActionButtonType> {
-  List<Widget> toKebabMenuWidgets(ActionButtonContext context, BuildContext buildContext, WidgetRef ref) {
-    if (isEmpty) {
       return [];
     }
 
     final List<Widget> result = [];
     int? lastGroup;
 
-    for (final type in this) {
+    for (final type in visibleButtons) {
       if (lastGroup != null && type.kebabMenuGroup != lastGroup) {
         result.add(const Divider(height: 1));
       }
-      final widget = type.buildButton(context, buildContext, false, true);
+      result.add(type.buildButton(context, buildContext, false, true).build(buildContext, ref));
-      result.add(widget is ConsumerWidget ? widget.build(buildContext, ref) : widget);
       lastGroup = type.kebabMenuGroup;
     }
 
     return result;
   }
-
-  List<Widget> toBottomBarWidgets(ActionButtonContext context, BuildContext buildContext, WidgetRef ref) {
-    return map((type) {
-      final widget = type.buildButton(context, buildContext, false, false);
-      return widget is ConsumerWidget ? widget.build(buildContext, ref) : widget;
-    }).toList();
-  }
 }

mobile/test/modules/activity/activity_provider_test.dart

@@ -108,9 +108,9 @@ void main() {
       expect(activities, hasLength(5));
       expect(activities, contains(like));
 
-      // Verify activity count is bumped for new likes
+      // Never bump activity count for new likes
-      verify(() => activityStatisticsMock.addActivity()).called(1);
+      verifyNever(() => activityStatisticsMock.addActivity());
-      verify(() => albumActivityStatisticsMock.addActivity()).called(1);
+      verifyNever(() => albumActivityStatisticsMock.addActivity());
 
       final albumActivities = container.read(albumProvider).requireValue;
       expect(albumActivities, hasLength(5));
@@ -155,9 +155,8 @@ void main() {
       expect(activities, hasLength(3));
       expect(activities, isNot(anyElement(predicate((Activity a) => a.id == '3'))));
 
-      // Verify activity count is decreased for removed likes
+      verifyNever(() => activityStatisticsMock.removeActivity());
-      verify(() => activityStatisticsMock.removeActivity()).called(1);
+      verifyNever(() => albumActivityStatisticsMock.removeActivity());
-      verify(() => albumActivityStatisticsMock.removeActivity()).called(1);
     });
 
     test('Remove Like failed', () async {
@@ -205,9 +204,8 @@ void main() {
       expect(albumActivities, isNot(anyElement(predicate((Activity a) => a.id == '3'))));
 
       verify(() => activityMock.removeActivity('3'));
-      // Verify activity count is decreased when removing from asset-scoped provider
+      verifyNever(() => activityStatisticsMock.removeActivity());
-      verify(() => activityStatisticsMock.removeActivity()).called(1);
+      verifyNever(() => albumActivityStatisticsMock.removeActivity());
-      verify(() => albumActivityStatisticsMock.removeActivity()).called(1);
     });
   });
 

mobile/test/modules/activity/activity_statistics_provider_test.dart

@@ -22,7 +22,7 @@ void main() {
   test('Returns the proper count family', () async {
     when(
       () => activityMock.getStatistics('test-album', assetId: 'test-asset'),
-    ).thenAnswer((_) async => const ActivityStats(comments: 5, likes: 0));
+    ).thenAnswer((_) async => const ActivityStats(comments: 5));
 
     // Read here to make the getStatistics call
     container.read(activityStatisticsProvider('test-album', 'test-asset'));
@@ -38,9 +38,7 @@ void main() {
   });
 
   test('Adds activity', () async {
-    when(
+    when(() => activityMock.getStatistics('test-album')).thenAnswer((_) async => const ActivityStats(comments: 10));
-      () => activityMock.getStatistics('test-album'),
-    ).thenAnswer((_) async => const ActivityStats(comments: 10, likes: 0));
 
     final provider = activityStatisticsProvider('test-album');
     container.listen(provider, listener.call, fireImmediately: true);
@@ -57,7 +55,7 @@ void main() {
   test('Removes activity', () async {
     when(
       () => activityMock.getStatistics('new-album', assetId: 'test-asset'),
-    ).thenAnswer((_) async => const ActivityStats(comments: 10, likes: 0));
+    ).thenAnswer((_) async => const ActivityStats(comments: 10));
 
     final provider = activityStatisticsProvider('new-album', 'test-asset');
     container.listen(provider, listener.call, fireImmediately: true);

mobile/test/utils/action_button_utils_test.dart

@@ -1,4 +1,3 @@
-import 'package:collection/collection.dart';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:immich_mobile/constants/enums.dart';
@@ -963,128 +962,4 @@ void main() {
       expect(nonArchivedWidgets, isNotEmpty);
     });
   });
-
-  group('ActionButtonBuilder.getViewerBottomBarTypes', () {
-    test('should return correct button types for shared album with activity', () {
-      final remoteAsset = createRemoteAsset();
-      final album = createRemoteAlbum(isActivityEnabled: true, isShared: true);
-      final context = ActionButtonContext(
-        asset: remoteAsset,
-        isOwner: true,
-        isArchived: false,
-        isTrashEnabled: true,
-        isInLockedView: false,
-        currentAlbum: album,
-        advancedTroubleshooting: false,
-        isStacked: false,
-        source: ActionSource.viewer,
-        buttonPosition: ButtonPosition.bottomBar,
-      );
-
-      const expectedTypes = [
-        ActionButtonType.share,
-        ActionButtonType.addTo,
-        ActionButtonType.openActivity,
-        ActionButtonType.likeActivity,
-      ];
-
-      final bottomBarTypes = ActionButtonBuilder.getViewerBottomBarTypes(context);
-      final kebabTypes = ActionButtonBuilder.getViewerKebabMenuTypes(context);
-
-      expect(const ListEquality().equals(bottomBarTypes, expectedTypes), isTrue);
-      expect(bottomBarTypes.any(kebabTypes.contains), isFalse);
-    });
-
-    test('should return correct button types for local only asset', () {
-      final localAsset = createLocalAsset();
-      final context = ActionButtonContext(
-        asset: localAsset,
-        isOwner: true,
-        isArchived: false,
-        isTrashEnabled: true,
-        isInLockedView: false,
-        currentAlbum: null,
-        advancedTroubleshooting: false,
-        isStacked: false,
-        source: ActionSource.viewer,
-        buttonPosition: ButtonPosition.bottomBar,
-      );
-
-      const expectedTypes = [
-        ActionButtonType.share,
-        ActionButtonType.upload,
-        ActionButtonType.editImage,
-        ActionButtonType.deleteLocal,
-      ];
-
-      final bottomBarTypes = ActionButtonBuilder.getViewerBottomBarTypes(context);
-      final kebabTypes = ActionButtonBuilder.getViewerKebabMenuTypes(
-        context.withButtonPosition(ButtonPosition.kebabMenu),
-      );
-
-      expect(const ListEquality().equals(bottomBarTypes, expectedTypes), isTrue);
-      expect(bottomBarTypes.any(kebabTypes.contains), isFalse);
-    });
-
-    test('should return correct button types for locked view', () {
-      final remoteAsset = createRemoteAsset();
-      final context = ActionButtonContext(
-        asset: remoteAsset,
-        isOwner: true,
-        isArchived: false,
-        isTrashEnabled: false,
-        isInLockedView: true,
-        currentAlbum: null,
-        advancedTroubleshooting: false,
-        isStacked: false,
-        source: ActionSource.viewer,
-        buttonPosition: ButtonPosition.bottomBar,
-      );
-
-      const expectedTypes = [
-        ActionButtonType.share,
-        ActionButtonType.removeFromLockFolder,
-        ActionButtonType.deletePermanent,
-      ];
-
-      final bottomBarTypes = ActionButtonBuilder.getViewerBottomBarTypes(context);
-      final kebabTypes = ActionButtonBuilder.getViewerKebabMenuTypes(
-        context.withButtonPosition(ButtonPosition.kebabMenu),
-      );
-
-      expect(const ListEquality().equals(bottomBarTypes, expectedTypes), isTrue);
-      expect(bottomBarTypes.any(kebabTypes.contains), isFalse);
-    });
-
-    test('should return correct button types for remote only asset', () {
-      final remoteAsset = createRemoteAsset();
-      final context = ActionButtonContext(
-        asset: remoteAsset,
-        isOwner: true,
-        isArchived: false,
-        isTrashEnabled: true,
-        isInLockedView: false,
-        currentAlbum: null,
-        advancedTroubleshooting: false,
-        isStacked: false,
-        source: ActionSource.viewer,
-        buttonPosition: ButtonPosition.bottomBar,
-      );
-
-      const expectedTypes = [
-        ActionButtonType.share,
-        ActionButtonType.editImage,
-        ActionButtonType.addTo,
-        ActionButtonType.delete,
-      ];
-
-      final bottomBarTypes = ActionButtonBuilder.getViewerBottomBarTypes(context);
-      final kebabTypes = ActionButtonBuilder.getViewerKebabMenuTypes(
-        context.withButtonPosition(ButtonPosition.kebabMenu),
-      );
-
-      expect(const ListEquality().equals(bottomBarTypes, expectedTypes), isTrue);
-      expect(bottomBarTypes.any(kebabTypes.contains), isFalse);
-    });
-  });
 }