chore(server,cli,web): housekeeping and stricter code style (#6751)

* add unicorn to eslint

* fix lint errors for cli

* fix merge

* fix album name extraction

* Update cli/src/commands/upload.command.ts

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* es2k23

* use lowercase os

* return undefined album name

* fix bug in asset response dto

* auto fix issues

* fix server code style

* es2022 and formatting

* fix compilation error

* fix test

* fix config load

* fix last lint errors

* set string type

* bump ts

* start work on web

* web formatting

* Fix UUIDParamDto as UUIDParamDto

* fix library service lint

* fix web errors

* fix errors

* formatting

* wip

* lints fixed

* web can now start

* alphabetical package json

* rename error

* chore: clean up

---------

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>

web/src/lib/components/album-page/__tests__/album-card.spec.ts

@@ -122,10 +122,10 @@ describe('AlbumCard component', () => {
       const onClickHandler = vi.fn();
       sut.component.$on('showalbumcontextmenu', onClickHandler);
 
-      const contextMenuBtnParent = sut.getByTestId('context-button-parent');
+      const contextMenuButtonParent = sut.getByTestId('context-button-parent');
 
       // Mock getBoundingClientRect to return a bounding rectangle that will result in the expected position
-      contextMenuBtnParent.getBoundingClientRect = () => ({
+      contextMenuButtonParent.getBoundingClientRect = () => ({
         x: 123,
         y: 456,
         width: 0,
@@ -138,7 +138,7 @@ describe('AlbumCard component', () => {
       });
 
       await fireEvent(
-        contextMenuBtnParent,
+        contextMenuButtonParent,
         new MouseEvent('click', {
           clientX: 123,
           clientY: 456,

web/src/lib/components/album-page/album-card.svelte

@@ -25,7 +25,7 @@
   const dispatchShowContextMenu = createEventDispatcher<OnShowContextMenu>();
 
   const loadHighQualityThumbnail = async (thubmnailId: string | null) => {
-    if (thubmnailId == null) {
+    if (thubmnailId == undefined) {
       return;
     }
 

web/src/lib/components/album-page/album-viewer.svelte

@@ -83,11 +83,12 @@
     }
     if (!$showAssetViewer) {
       switch (event.key) {
-        case 'Escape':
+        case 'Escape': {
           if ($isMultiSelectState) {
             assetInteractionStore.clearMultiselect();
           }
           return;
+        }
       }
     }
   };

web/src/lib/components/album-page/share-info-modal.svelte

@@ -30,8 +30,8 @@
     try {
       const { data } = await api.userApi.getMyUserInfo();
       currentUser = data;
-    } catch (e) {
-      handleError(e, 'Unable to refresh user');
+    } catch (error) {
+      handleError(error, 'Unable to refresh user');
     }
   });
 
@@ -58,8 +58,8 @@
       dispatch('remove', userId);
       const message = userId === 'me' ? `Left ${album.albumName}` : `Removed ${selectedRemoveUser.name}`;
       notificationController.show({ type: NotificationType.Info, message });
-    } catch (e) {
-      handleError(e, 'Unable to remove user');
+    } catch (error) {
+      handleError(error, 'Unable to remove user');
     } finally {
       selectedRemoveUser = null;
     }

web/src/lib/components/album-page/thumbnail-selection.svelte

@@ -16,11 +16,7 @@
   }>();
 
   $: isSelected = (id: string): boolean | undefined => {
-    if (!selectedThumbnail && album.albumThumbnailAssetId == id) {
-      return true;
-    } else {
-      return selectedThumbnail?.id == id;
-    }
+    return !selectedThumbnail && album.albumThumbnailAssetId == id ? true : selectedThumbnail?.id == id;
   };
 </script>
 

web/src/lib/components/album-page/user-selection-modal.svelte

@@ -28,9 +28,9 @@
     users = data.filter((user) => !(user.deletedAt || user.id === album.ownerId));
 
     // Remove the existed shared users from the album
-    album.sharedUsers.forEach((sharedUser) => {
+    for (const sharedUser of album.sharedUsers) {
       users = users.filter((user) => user.id !== sharedUser.id);
-    });
+    }
   });
 
   const getSharedLinks = async () => {
@@ -40,11 +40,9 @@
   };
 
   const handleSelect = (user: UserResponseDto) => {
-    if (selectedUsers.includes(user)) {
-      selectedUsers = selectedUsers.filter((selectedUser) => selectedUser.id !== user.id);
-    } else {
-      selectedUsers = [...selectedUsers, user];
-    }
+    selectedUsers = selectedUsers.includes(user)
+      ? selectedUsers.filter((selectedUser) => selectedUser.id !== user.id)
+      : [...selectedUsers, user];
   };
 
   const handleUnselect = (user: UserResponseDto) => {
@@ -122,7 +120,7 @@
         size="sm"
         fullwidth
         rounded="full"
-        disabled={!selectedUsers.length}
+        disabled={selectedUsers.length === 0}
         on:click={() => dispatch('select', selectedUsers)}>Add</Button
       >
     </div>