immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-18 01:11:07 +03:00
Code Issues Packages Projects Releases 16 Wiki Activity

Optimize mobile - Avoid creating unnecessary widgets (#268)

Browse Source 
* Avoid creating unnecessary widgets

* more flexible null handling and runtime errors prevention
This commit is contained in:
xpwmaosldk
2022-07-01 10:08:49 +09:00
committed by GitHub
parent 992f792c0a
commit c4ef523564
29 changed files with 369 additions and 450 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
mobile/lib/shared/providers/websocket.provider.dart
View File

@@ -104,10 +104,9 @@ class WebsocketNotifier extends StateNotifier<WebscoketState> {
disconnect() {
debugPrint("[WEBSOCKET] Attempting to disconnect");
var socket = state.socket?.disconnect();
if (socket != null) {
if (socket.disconnected) {
state = WebscoketState(isConnected: false, socket: null);
}
if (socket?.disconnected == true) {
state = WebscoketState(isConnected: false, socket: null);
}
}

2
mobile/lib/shared/views/splash_screen.dart
View File

@@ -34,7 +34,7 @@ class SplashScreenPage extends HookConsumerWidget {
}
useEffect(() {
if (loginInfo != null && loginInfo.isSaveLogin) {
if (loginInfo?.isSaveLogin == true) {
performLoggingIn();
} else {
AutoRouter.of(context).push(const LoginRoute());

2
mobile/lib/shared/views/version_announcement_overlay.dart
View File

@@ -121,7 +121,7 @@ class VersionAnnouncementOverlay extends HookConsumerWidget {
),
);
} else {
return Container();
return const SizedBox();
}
},
);