immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-20 17:25:35 +03:00
Code Issues Packages Projects Releases 18 Wiki Activity

fix(web): easier alt text translation for other languages (#11124)

Browse Source 
* fix(web): alt text translation for non-English languages

* fix: refactor to use full translation key names

* fix: calling the translation function directly
This commit is contained in:
Ben
2024-07-26 14:48:40 -04:00
committed by GitHub
parent ce15cf6065
commit c037a8b8fa
3 changed files with 98 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
web/src/lib/utils/thumbnail-util.spec.ts
View File

@@ -2,6 +2,11 @@ import { getAltText } from '$lib/utils/thumbnail-util';
import { AssetTypeEnum, type AssetResponseDto } from '@immich/sdk';
import { init, register, waitLocale } from 'svelte-i18n';
const onePerson = [{ name: 'person' }];
const twoPeople = [{ name: 'person1' }, { name: 'person2' }];
const threePeople = [{ name: 'person1' }, { name: 'person2' }, { name: 'person3' }];
const fourPeople = [{ name: 'person1' }, { name: 'person2' }, { name: 'person3' }, { name: 'person4' }];
describe('getAltText', () => {
beforeAll(async () => {
await init({ fallbackLocale: 'en-US' });
@@ -9,6 +14,44 @@ describe('getAltText', () => {
await waitLocale('en-US');
});
it.each`
isVideo | city | country | people | expected
${false} | ${undefined} | ${'country'} | ${undefined} | ${'Image taken on January 1, 2024'}
${true} | ${'city'} | ${undefined} | ${undefined} | ${'Video taken on January 1, 2024'}
${false} | ${'city'} | ${'country'} | ${[]} | ${'Image taken in city, country on January 1, 2024'}
${true} | ${'city'} | ${'country'} | ${[]} | ${'Video taken in city, country on January 1, 2024'}
${false} | ${undefined} | ${undefined} | ${onePerson} | ${'Image taken with person on January 1, 2024'}
${false} | ${undefined} | ${undefined} | ${twoPeople} | ${'Image taken with person1 and person2 on January 1, 2024'}
${false} | ${undefined} | ${undefined} | ${threePeople} | ${'Image taken with person1, person2, and person3 on January 1, 2024'}
${false} | ${undefined} | ${undefined} | ${fourPeople} | ${'Image taken with person1, person2, and 2 others on January 1, 2024'}
${false} | ${'city'} | ${'country'} | ${onePerson} | ${'Image taken in city, country with person on January 1, 2024'}
${false} | ${'city'} | ${'country'} | ${twoPeople} | ${'Image taken in city, country with person1 and person2 on January 1, 2024'}
${false} | ${'city'} | ${'country'} | ${threePeople} | ${'Image taken in city, country with person1, person2, and person3 on January 1, 2024'}
${false} | ${'city'} | ${'country'} | ${fourPeople} | ${'Image taken in city, country with person1, person2, and 2 others on January 1, 2024'}
${true} | ${undefined} | ${undefined} | ${onePerson} | ${'Video taken with person on January 1, 2024'}
${true} | ${undefined} | ${undefined} | ${twoPeople} | ${'Video taken with person1 and person2 on January 1, 2024'}
${true} | ${undefined} | ${undefined} | ${threePeople} | ${'Video taken with person1, person2, and person3 on January 1, 2024'}
${true} | ${undefined} | ${undefined} | ${fourPeople} | ${'Video taken with person1, person2, and 2 others on January 1, 2024'}
${true} | ${'city'} | ${'country'} | ${onePerson} | ${'Video taken in city, country with person on January 1, 2024'}
${true} | ${'city'} | ${'country'} | ${twoPeople} | ${'Video taken in city, country with person1 and person2 on January 1, 2024'}
${true} | ${'city'} | ${'country'} | ${threePeople} | ${'Video taken in city, country with person1, person2, and person3 on January 1, 2024'}
${true} | ${'city'} | ${'country'} | ${fourPeople} | ${'Video taken in city, country with person1, person2, and 2 others on January 1, 2024'}
`(
'generates correctly formatted alt text when isVideo=$isVideo, city=$city, country=$country, people=$people.length',
({ isVideo, city, country, people, expected }) => {
const asset = {
exifInfo: { city, country },
localDateTime: '2024-01-01T12:00:00.000Z',
people,
type: isVideo ? AssetTypeEnum.Video : AssetTypeEnum.Image,
} as AssetResponseDto;
getAltText.subscribe((fn) => {
expect(fn(asset)).toEqual(expected);
});
},
);
it('defaults to the description, if available', () => {
const asset = {
exifInfo: { description: 'description' },
@@ -18,51 +61,4 @@ describe('getAltText', () => {
expect(fn(asset)).toEqual('description');
});
});
it('includes the city and country', () => {
const asset = {
exifInfo: { city: 'city', country: 'country' },
localDateTime: '2024-01-01T12:00:00.000Z',
} as AssetResponseDto;
getAltText.subscribe((fn) => {
expect(fn(asset)).toEqual('Image taken in city, country on January 1, 2024');
});
});
// convert the people tests into an it.each
it.each([
[[{ name: 'person' }], 'Image taken with person on January 1, 2024'],
[[{ name: 'person1' }, { name: 'person2' }], 'Image taken with person1 and person2 on January 1, 2024'],
[
[{ name: 'person1' }, { name: 'person2' }, { name: 'person3' }],
'Image taken with person1, person2, and person3 on January 1, 2024',
],
[
[{ name: 'person1' }, { name: 'person2' }, { name: 'person3' }, { name: 'person4' }],
'Image taken with person1, person2, and 2 others on January 1, 2024',
],
])('includes people, correctly formatted', (people, expected) => {
const asset = {
localDateTime: '2024-01-01T12:00:00.000Z',
people,
} as AssetResponseDto;
getAltText.subscribe((fn) => {
expect(fn(asset)).toEqual(expected);
});
});
it('handles videos, location, people, and date', () => {
const asset = {
exifInfo: { city: 'city', country: 'country' },
localDateTime: '2024-01-01T12:00:00.000Z',
people: [{ name: 'person1' }, { name: 'person2' }, { name: 'person3' }, { name: 'person4' }, { name: 'person5' }],
type: AssetTypeEnum.Video,
} as AssetResponseDto;
getAltText.subscribe((fn) => {
expect(fn(asset)).toEqual('Video taken in city, country with person1, person2, and 3 others on January 1, 2024');
});
});
});