immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-23 01:11:36 +03:00
Code Issues Packages Projects Releases 18 Wiki Activity

feat(server): validate rating (#12855)

Browse Source 
* feat(server): validate exif rating tag

* fix(server): change allowed range for rating

* refactor: better readibility

* docs: comments

* remove log line
This commit is contained in:
Nuno Antunes
2024-09-23 08:50:18 +01:00
committed by GitHub
parent 147747de32
commit b1cdf73a24
2 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
server/src/services/metadata.service.spec.ts
View File

@@ -1107,6 +1107,30 @@ describe(MetadataService.name, () => {
}),
);
});
it('should handle invalid rating value', async () => {
assetMock.getByIds.mockResolvedValue([assetStub.image]);
metadataMock.readTags.mockResolvedValue({ Rating: 6 });
await sut.handleMetadataExtraction({ id: assetStub.image.id });
expect(assetMock.upsertExif).toHaveBeenCalledWith(
expect.objectContaining({
rating: null,
}),
);
});
it('should handle valid rating value', async () => {
assetMock.getByIds.mockResolvedValue([assetStub.image]);
metadataMock.readTags.mockResolvedValue({ Rating: 5 });
await sut.handleMetadataExtraction({ id: assetStub.image.id });
expect(assetMock.upsertExif).toHaveBeenCalledWith(
expect.objectContaining({
rating: 5,
}),
);
});
});
describe('handleQueueSidecar', () => {