fix: mobile unawaited_futures lint (#21661)

* chore: add unawaited_futures lint as warning # Conflicts: # mobile/analysis_options.yaml * remove unused dcm lints They will be added back later on a case by case basis * fix warning # Conflicts: # mobile/lib/presentation/pages/drift_remote_album.page.dart * auto gen file * review changes * conflict resolution --------- Co-authored-by: shenlong-tanwen <139912620+shalong-tanwen@users.noreply.github.com>
2025-12-20 17:25:35 +03:00 · 2025-10-27 20:02:52 +05:30
parent 664a8fa499
commit ac0d646401
88 changed files with 491 additions and 538 deletions
--- a/mobile/lib/services/action.service.dart
+++ b/mobile/lib/services/action.service.dart
@@ -1,3 +1,5 @@
+import 'dart:async';
+
 import 'package:auto_route/auto_route.dart';
 import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
@@ -50,7 +52,7 @@ class ActionService {
  );

  Future<void> shareLink(List<String> remoteIds, BuildContext context) async {
-    context.pushRoute(SharedLinkEditRoute(assetsList: remoteIds));
+    unawaited(context.pushRoute(SharedLinkEditRoute(assetsList: remoteIds)));
  }

  Future<void> favorite(List<String> remoteIds) async {
--- a/mobile/lib/services/album.service.dart
+++ b/mobile/lib/services/album.service.dart
@@ -83,7 +83,7 @@ class AlbumService {
      if (selectedIds.isEmpty) {
        final numLocal = await _albumRepository.count(local: true);
        if (numLocal > 0) {
-          _syncService.removeAllLocalAlbumsAndAssets();
+          await _syncService.removeAllLocalAlbumsAndAssets();
        }
        return false;
      }
--- a/mobile/lib/services/api.service.dart
+++ b/mobile/lib/services/api.service.dart
@@ -6,11 +6,11 @@ import 'package:device_info_plus/device_info_plus.dart';
 import 'package:http/http.dart';
 import 'package:immich_mobile/domain/models/store.model.dart';
 import 'package:immich_mobile/entities/store.entity.dart';
+import 'package:immich_mobile/utils/debug_print.dart';
 import 'package:immich_mobile/utils/url_helper.dart';
+import 'package:immich_mobile/utils/user_agent.dart';
 import 'package:logging/logging.dart';
 import 'package:openapi/api.dart';
-import 'package:immich_mobile/utils/user_agent.dart';
-import 'package:immich_mobile/utils/debug_print.dart';

 class ApiService implements Authentication {
  late ApiClient _apiClient;
@@ -86,7 +86,7 @@ class ApiService implements Authentication {
    setEndpoint(endpoint);

    // Save in local database for next startup
-    Store.put(StoreKey.serverEndpoint, endpoint);
+    await Store.put(StoreKey.serverEndpoint, endpoint);
    return endpoint;
  }

--- a/mobile/lib/services/auth.service.dart
+++ b/mobile/lib/services/auth.service.dart
@@ -58,7 +58,7 @@ class AuthService {
  Future<String> validateServerUrl(String url) async {
    final validUrl = await _apiService.resolveAndSetEndpoint(url);
    await _apiService.setDeviceInfoHeader();
-    Store.put(StoreKey.serverUrl, validUrl);
+    await Store.put(StoreKey.serverUrl, validUrl);

    return validUrl;
  }
--- a/mobile/lib/services/background.service.dart
+++ b/mobile/lib/services/background.service.dart
@@ -291,7 +291,7 @@ class BackgroundService {
      case "backgroundProcessing":
      case "onAssetsChanged":
        try {
-          _clearErrorNotifications();
+          unawaited(_clearErrorNotifications());

          // iOS should time out after some threshold so it doesn't wait
          // indefinitely and can run later
@@ -342,7 +342,7 @@ class BackgroundService {
    );

    HttpSSLOptions.apply();
-    ref.read(apiServiceProvider).setAccessToken(Store.get(StoreKey.accessToken));
+    await ref.read(apiServiceProvider).setAccessToken(Store.get(StoreKey.accessToken));
    await ref.read(authServiceProvider).setOpenApiServiceEndpoint();
    dPrint(() => "[BG UPLOAD] Using endpoint: ${ref.read(apiServiceProvider).apiClient.basePath}");

@@ -385,7 +385,7 @@ class BackgroundService {
        await ref.read(backupAlbumRepositoryProvider).deleteAll(toDelete);
        await ref.read(backupAlbumRepositoryProvider).updateAll(toUpsert);
      } else if (Store.tryGet(StoreKey.backupFailedSince) == null) {
-        Store.put(StoreKey.backupFailedSince, DateTime.now());
+        await Store.put(StoreKey.backupFailedSince, DateTime.now());
        return false;
      }
      // Android should check for new assets added while performing backup
@@ -412,9 +412,11 @@ class BackgroundService {
    try {
      toUpload = await backupService.removeAlreadyUploadedAssets(toUpload);
    } catch (e) {
-      _showErrorNotification(
-        title: "backup_background_service_error_title".tr(),
-        content: "backup_background_service_connection_failed_message".tr(),
+      unawaited(
+        _showErrorNotification(
+          title: "backup_background_service_error_title".tr(),
+          content: "backup_background_service_connection_failed_message".tr(),
+        ),
      );
      return false;
    }
@@ -428,13 +430,15 @@ class BackgroundService {
    }
    _assetsToUploadCount = toUpload.length;
    _uploadedAssetsCount = 0;
-    _updateNotification(
-      title: "backup_background_service_in_progress_notification".tr(),
-      content: notifyTotalProgress ? formatAssetBackupProgress(_uploadedAssetsCount, _assetsToUploadCount) : null,
-      progress: 0,
-      max: notifyTotalProgress ? _assetsToUploadCount : 0,
-      indeterminate: !notifyTotalProgress,
-      onlyIfFG: !notifyTotalProgress,
+    unawaited(
+      _updateNotification(
+        title: "backup_background_service_in_progress_notification".tr(),
+        content: notifyTotalProgress ? formatAssetBackupProgress(_uploadedAssetsCount, _assetsToUploadCount) : null,
+        progress: 0,
+        max: notifyTotalProgress ? _assetsToUploadCount : 0,
+        indeterminate: !notifyTotalProgress,
+        onlyIfFG: !notifyTotalProgress,
+      ),
    );

    _cancellationToken = CancellationToken();
@@ -452,9 +456,11 @@ class BackgroundService {
    );

    if (!ok && !_cancellationToken!.isCancelled) {
-      _showErrorNotification(
-        title: "backup_background_service_error_title".tr(),
-        content: "backup_background_service_backup_failed_message".tr(),
+      unawaited(
+        _showErrorNotification(
+          title: "backup_background_service_error_title".tr(),
+          content: "backup_background_service_backup_failed_message".tr(),
+        ),
      );
    }

--- a/mobile/lib/services/backup_verification.service.dart
+++ b/mobile/lib/services/backup_verification.service.dart
@@ -120,7 +120,7 @@ class BackupVerificationService {
    await tuple.fileMediaRepository.enableBackgroundAccess();
    final ApiService apiService = ApiService();
    apiService.setEndpoint(tuple.endpoint);
-    apiService.setAccessToken(tuple.auth);
+    await apiService.setAccessToken(tuple.auth);
    for (int i = 0; i < tuple.deleteCandidates.length; i++) {
      if (await _compareAssets(tuple.deleteCandidates[i], tuple.originals[i], apiService)) {
        result.add(tuple.deleteCandidates[i]);
--- a/mobile/lib/services/map.service.dart
+++ b/mobile/lib/services/map.service.dart
@@ -1,9 +1,9 @@
 import 'package:immich_mobile/mixins/error_logger.mixin.dart';
 import 'package:immich_mobile/models/map/map_marker.model.dart';
 import 'package:immich_mobile/services/api.service.dart';
+import 'package:immich_mobile/utils/user_agent.dart';
 import 'package:logging/logging.dart';
 import 'package:maplibre_gl/maplibre_gl.dart';
-import 'package:immich_mobile/utils/user_agent.dart';

 class MapService with ErrorLoggerMixin {
  final ApiService _apiService;
@@ -16,7 +16,7 @@ class MapService with ErrorLoggerMixin {

  Future<void> _setMapUserAgentHeader() async {
    final userAgent = await getUserAgentString();
-    setHttpHeaders({'User-Agent': userAgent});
+    await setHttpHeaders({'User-Agent': userAgent});
  }

  Future<Iterable<MapMarker>> getMapMarkers({
--- a/mobile/lib/services/share.service.dart
+++ b/mobile/lib/services/share.service.dart
@@ -1,13 +1,15 @@
+import 'dart:async';
 import 'dart:io';

 import 'package:flutter/material.dart';
 import 'package:hooks_riverpod/hooks_riverpod.dart';
-import 'package:immich_mobile/extensions/response_extensions.dart';
 import 'package:immich_mobile/entities/asset.entity.dart';
+import 'package:immich_mobile/extensions/response_extensions.dart';
 import 'package:immich_mobile/providers/api.provider.dart';
 import 'package:logging/logging.dart';
 import 'package:path_provider/path_provider.dart';
 import 'package:share_plus/share_plus.dart';
+
 import 'api.service.dart';

 final shareServiceProvider = Provider((ref) => ShareService(ref.watch(apiServiceProvider)));
@@ -58,9 +60,11 @@ class ShareService {
      }

      final size = MediaQuery.of(context).size;
-      Share.shareXFiles(
-        downloadedXFiles,
-        sharePositionOrigin: Rect.fromPoints(Offset.zero, Offset(size.width / 3, size.height)),
+      unawaited(
+        Share.shareXFiles(
+          downloadedXFiles,
+          sharePositionOrigin: Rect.fromPoints(Offset.zero, Offset(size.width / 3, size.height)),
+        ),
      );
      return true;
    } catch (error) {
--- a/mobile/lib/services/sync.service.dart
+++ b/mobile/lib/services/sync.service.dart
@@ -705,7 +705,7 @@ class SyncService {
    if (assets.isEmpty) return;

    if (Platform.isAndroid && _appSettingsService.getSetting<bool>(AppSettingsEnum.manageLocalMediaAndroid)) {
-      _toggleTrashStatusForAssets(assets);
+      await _toggleTrashStatusForAssets(assets);
    }

    try {
--- a/mobile/lib/services/upload.service.dart
+++ b/mobile/lib/services/upload.service.dart
@@ -214,7 +214,7 @@ class UploadService {
  void _handleTaskStatusUpdate(TaskStatusUpdate update) async {
    switch (update.status) {
      case TaskStatus.complete:
-        _handleLivePhoto(update);
+        unawaited(_handleLivePhoto(update));

        if (CurrentPlatform.isIOS) {
          try {
@@ -259,7 +259,7 @@ class UploadService {
        return;
      }

-      enqueueTasks([uploadTask]);
+      await enqueueTasks([uploadTask]);
    } catch (error, stackTrace) {
      dPrint(() => "Error handling live photo upload task: $error $stackTrace");
    }