fix(web): avoid nesting buttons inside links (#11425)

This commit is contained in:
Michel Heusschen
2024-07-29 16:36:10 +02:00
committed by GitHub
parent 7bb7f63d57
commit 2e059bfbfd
15 changed files with 216 additions and 96 deletions

View File

@@ -1,5 +1,4 @@
<script lang="ts">
import { goto } from '$app/navigation';
import empty2Url from '$lib/assets/empty-2.svg';
import LinkButton from '$lib/components/elements/buttons/link-button.svelte';
import Icon from '$lib/components/elements/icon.svelte';
@@ -43,7 +42,7 @@
</div>
</LinkButton>
<LinkButton on:click={() => goto(AppRoute.SHARED_LINKS)}>
<LinkButton href={AppRoute.SHARED_LINKS}>
<div class="flex flex-wrap place-items-center justify-center gap-x-1 text-sm">
<Icon path={mdiLink} size="18" class="shrink-0" />
<span class="leading-none max-sm:text-xs">{$t('shared_links')}</span>

View File

@@ -11,10 +11,8 @@
<ImmichLogo noText class="text-center" height="200" width="200" />
</div>
<h1 class="text-4xl font-bold text-immich-primary dark:text-immich-dark-primary">{$t('welcome_to_immich')}</h1>
<a href={AppRoute.AUTH_REGISTER}>
<Button size="lg" rounded="lg">
<span class="px-2 font-bold">{$t('getting_started')}</span>
</Button>
</a>
<Button href={AppRoute.AUTH_REGISTER} size="lg" rounded="lg">
<span class="px-2 font-bold">{$t('getting_started')}</span>
</Button>
</div>
</section>

View File

@@ -31,14 +31,12 @@
<UserPageLayout title={data.meta.title} admin>
<div class="flex justify-end" slot="buttons">
<a href="{AppRoute.ADMIN_SETTINGS}?isOpen=job">
<LinkButton>
<div class="flex place-items-center gap-2 text-sm">
<Icon path={mdiCog} size="18" />
{$t('admin.manage_concurrency')}
</div>
</LinkButton>
</a>
<LinkButton href="{AppRoute.ADMIN_SETTINGS}?isOpen=job">
<div class="flex place-items-center gap-2 text-sm">
<Icon path={mdiCog} size="18" />
{$t('admin.manage_concurrency')}
</div>
</LinkButton>
</div>
<section id="setting-content" class="flex place-content-center sm:mx-4">
<section class="w-full pb-28 sm:w-5/6 md:w-[850px]">