immich-app/immich
1
0
Fork 0
mirror of https://github.com/immich-app/immich.git synced 2025-12-25 01:11:43 +03:00
Code Issues Packages Projects Releases 18 Wiki Activity

fix(sql-tools): null default (#20796)

Browse Source
This commit is contained in:
Jason Rasmussen
2025-08-08 15:44:39 -04:00
committed by GitHub
parent 538d5c81ea
commit 2ce4f8dd3b
4 changed files with 34 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
server/src/sql-tools/comparers/column.comparer.spec.ts
View File

@@ -62,6 +62,23 @@ describe('compareColumns', () => {
]);
});
it('should detect a change in default', () => {
const source: DatabaseColumn = { ...testColumn, nullable: true };
const target: DatabaseColumn = { ...testColumn, nullable: true, default: "''" };
const reason = `default is different (null vs '')`;
expect(compareColumns.onCompare(source, target)).toEqual([
{
columnName: 'test',
tableName: 'table1',
type: 'ColumnAlter',
changes: {
default: 'NULL',
},
reason,
},
]);
});
it('should detect a comment change', () => {
const source: DatabaseColumn = { ...testColumn, comment: 'new comment' };
const target: DatabaseColumn = { ...testColumn, comment: 'old comment' };

4
server/src/sql-tools/comparers/column.comparer.ts
View File

@@ -72,9 +72,9 @@ export const compareColumns = {
tableName: source.tableName,
columnName: source.name,
changes: {
default: String(source.default),
default: String(source.default ?? 'NULL'),
},
reason: `default is different (${source.default} vs ${target.default})`,
reason: `default is different (${source.default ?? 'null'} vs ${target.default})`,
});
}