chore: mock the app restart callback

This commit is contained in:
izzy
2025-12-19 14:08:31 +00:00
parent ec63098020
commit 00bafb899d
2 changed files with 13 additions and 9 deletions

View File

@@ -5,6 +5,8 @@ import { factory } from 'test/small.factory';
import { newTestService, ServiceMocks } from 'test/utils'; import { newTestService, ServiceMocks } from 'test/utils';
import { describe, it } from 'vitest'; import { describe, it } from 'vitest';
const mockSendRestart = vi.fn();
describe(CliService.name, () => { describe(CliService.name, () => {
let sut: CliService; let sut: CliService;
let mocks: ServiceMocks; let mocks: ServiceMocks;
@@ -85,7 +87,7 @@ describe(CliService.name, () => {
describe('disableMaintenanceMode', () => { describe('disableMaintenanceMode', () => {
it('should not do anything if not in maintenance mode', async () => { it('should not do anything if not in maintenance mode', async () => {
mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: false }); mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: false });
await expect(sut.disableMaintenanceMode()).resolves.toEqual({ await expect(sut.disableMaintenanceMode(mockSendRestart)).resolves.toEqual({
alreadyDisabled: true, alreadyDisabled: true,
}); });
@@ -95,7 +97,7 @@ describe(CliService.name, () => {
it('should disable maintenance mode', async () => { it('should disable maintenance mode', async () => {
mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' }); mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' });
await expect(sut.disableMaintenanceMode()).resolves.toEqual({ await expect(sut.disableMaintenanceMode(mockSendRestart)).resolves.toEqual({
alreadyDisabled: false, alreadyDisabled: false,
}); });
@@ -108,7 +110,7 @@ describe(CliService.name, () => {
describe('enableMaintenanceMode', () => { describe('enableMaintenanceMode', () => {
it('should not do anything if in maintenance mode', async () => { it('should not do anything if in maintenance mode', async () => {
mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' }); mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' });
await expect(sut.enableMaintenanceMode()).resolves.toEqual( await expect(sut.enableMaintenanceMode(mockSendRestart)).resolves.toEqual(
expect.objectContaining({ expect.objectContaining({
alreadyEnabled: true, alreadyEnabled: true,
}), }),
@@ -120,7 +122,7 @@ describe(CliService.name, () => {
it('should enable maintenance mode', async () => { it('should enable maintenance mode', async () => {
mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: false }); mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: false });
await expect(sut.enableMaintenanceMode()).resolves.toEqual( await expect(sut.enableMaintenanceMode(mockSendRestart)).resolves.toEqual(
expect.objectContaining({ expect.objectContaining({
alreadyEnabled: false, alreadyEnabled: false,
}), }),
@@ -137,7 +139,7 @@ describe(CliService.name, () => {
it('should return a valid login URL', async () => { it('should return a valid login URL', async () => {
mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' }); mocks.systemMetadata.get.mockResolvedValue({ isMaintenanceMode: true, secret: 'secret' });
const result = await sut.enableMaintenanceMode(); const result = await sut.enableMaintenanceMode(mockSendRestart);
expect(result).toEqual( expect(result).toEqual(
expect.objectContaining({ expect.objectContaining({

View File

@@ -42,7 +42,7 @@ export class CliService extends BaseService {
await this.updateConfig(config); await this.updateConfig(config);
} }
async disableMaintenanceMode(): Promise<{ alreadyDisabled: boolean }> { async disableMaintenanceMode(sendAppRestartCallback = sendOneShotAppRestart): Promise<{ alreadyDisabled: boolean }> {
const currentState = await this.systemMetadataRepository const currentState = await this.systemMetadataRepository
.get(SystemMetadataKey.MaintenanceMode) .get(SystemMetadataKey.MaintenanceMode)
.then((state) => state ?? { isMaintenanceMode: false as const }); .then((state) => state ?? { isMaintenanceMode: false as const });
@@ -56,14 +56,16 @@ export class CliService extends BaseService {
const state = { isMaintenanceMode: false as const }; const state = { isMaintenanceMode: false as const };
await this.systemMetadataRepository.set(SystemMetadataKey.MaintenanceMode, state); await this.systemMetadataRepository.set(SystemMetadataKey.MaintenanceMode, state);
await sendOneShotAppRestart(state); await sendAppRestartCallback(state);
return { return {
alreadyDisabled: false, alreadyDisabled: false,
}; };
} }
async enableMaintenanceMode(): Promise<{ authUrl: string; alreadyEnabled: boolean }> { async enableMaintenanceMode(
sendAppRestartCallback = sendOneShotAppRestart,
): Promise<{ authUrl: string; alreadyEnabled: boolean }> {
const { server } = await this.getConfig({ withCache: true }); const { server } = await this.getConfig({ withCache: true });
const baseUrl = getExternalDomain(server); const baseUrl = getExternalDomain(server);
@@ -89,7 +91,7 @@ export class CliService extends BaseService {
secret, secret,
}); });
await sendOneShotAppRestart({ await sendAppRestartCallback({
isMaintenanceMode: true, isMaintenanceMode: true,
}); });