dualshock-tools/dualshock-tools.github.io
1
0
Fork 0
mirror of https://github.com/dualshock-tools/dualshock-tools.github.io.git synced 2026-03-01 11:19:54 +03:00
Code Issues 9 Packages Projects Releases Wiki Activity

[PR #138] [MERGED] Reintroduce broken code to un-break the writing of finetune changes to Edge modules #160

New Issue
Closed
opened 2026-02-10 18:47:27 +03:00 by OVERLORD · 0 comments
OVERLORD commented 2026-02-10 18:47:27 +03:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dualshock-tools/dualshock-tools.github.io/pull/138
Author: @mathiasm74
Created: 9/13/2025
Status: ✅ Merged
Merged: 9/13/2025
Merged by: @dualshock-tools

Base: main ← Head: fix-finetune-changes-not-written-to-edge-controllers

📝 Commits (1)

  • d03392e Reintroduce broken code to un-break the writing of finetune changes to Edge modules

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 core.js (+4 -3)

📄 Description

Comparing two different array objects will never evaluate to true in Javascript.
However fixing the code (as I did) breaks the code path for writing finetune changes to Edge modules.

This PR reintroduces the old behaviour, but the proper fix is to either remove the test entirely, or restructure the code so that it works properly when the comparison statement is correct.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dualshock-tools/dualshock-tools.github.io/pull/138 **Author:** [@mathiasm74](https://github.com/mathiasm74) **Created:** 9/13/2025 **Status:** ✅ Merged **Merged:** 9/13/2025 **Merged by:** [@dualshock-tools](https://github.com/dualshock-tools) **Base:** `main` ← **Head:** `fix-finetune-changes-not-written-to-edge-controllers` --- ### 📝 Commits (1) - [`d03392e`](https://github.com/dualshock-tools/dualshock-tools.github.io/commit/d03392ef2102080dbf09a550ce9251f3e3e5811d) Reintroduce broken code to un-break the writing of finetune changes to Edge modules ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `core.js` (+4 -3) </details> ### 📄 Description Comparing two different array objects will never evaluate to true in Javascript. However fixing the code (as I did) breaks the code path for writing finetune changes to Edge modules. This PR reintroduces the old behaviour, but the proper fix is to either remove the test entirely, or restructure the code so that it works properly when the comparison statement is correct. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
OVERLORD added the pull-request label 2026-02-10 18:47:27 +03:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
OVERLORD
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: dualshock-tools/dualshock-tools.github.io#160
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?